Repository navigation
Third-party stubs: enforce CamelCase for type alias names - #8256
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
A lot of aliases are marked as type aliases that I wouldn't consider type aliases. In my opinion as soon as an alias is used at runtime, I wouldn't consider it a type aliases. Examples are |
I agree that these don't need to be type aliases necessarily. @hauntsaninja raised some objections the last time I tried to remove those markers from some of them (#8248 (review)), but I also don't think he has a strong objection (#8248 (review)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| # Ignore Y026, this isn't a type alias. | ||
| # We have to do `ordered_column_set = OrderedSet[_T] | ||
| # instead of `ordered_column_set = OrderedSet`, | ||
| # or pyright complains |
There was a problem hiding this comment.
Why doesn't pyright complain about column_set?
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
One optional suggestion
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Unblocks PyCQA/flake8-pyi#243