Repository navigation
Fix various TypeAlias issues - #8248
Conversation
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
The reasoning behind removing the conditional type alias annotations isn't clear to me
Yeah, tbh I'm slightly unsure for those ones about whether it's better to consider them as type aliases or variable aliases. Happy to revert those changes if you think it's better the way it is; don't really have a strong opinion there. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! These are simple and uncontroversial. I don't have a strong opinion on the removed ones, so if there is some benefit feel free to open another PR.
I thought there were some benefits, but I was playing around on mypy playground and couldn't find any reason to make the change in terms of actually improving the stub. It reduces the hits from PyCQA/flake8-pyi#240, but I think that that approach probably isn't viable anyway, so I don't think that's a good reason to make those changes |
Refs PyCQA/flake8-pyi#240