Skip to content

Support the PSR17 request factory - #190

Merged
dbu merged 1 commit into
php-http:masterfrom
GrahamCampbell:patch-1
Jul 1, 2020
Merged

dbu merged 1 commit into
php-http:masterfrom
GrahamCampbell:patch-1

Conversation

@GrahamCampbell

@GrahamCampbell GrahamCampbell commented Jun 30, 2020 •

Copy link
Copy Markdown
Contributor
Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Http\Discovery\MessageFactoryDiscovery is deprecated, so there is no way to discover a Http\Message\RequestFactory instance using non-deprecated APIs. Http\Client\Common\HttpMethodsClient should therefore except a PSR17 request factory Psr\Http\Message\RequestFactoryInterface as well as a Http\Message\RequestFactory.

@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

The CI failings are not related to my PR, and can be fixed separately.

@dbu dbu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some minor cleanup, otherwise looks good.

i fixed the cs failure in master, if you could rebase the build should become green.

Comment thread composer.json Resolved
Comment thread src/HttpMethodsClient.php Resolved
Comment thread composer.json Resolved
@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

So it turns out this doesn't work quite how we expected! #202 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants