Skip to content

HttpMethodsClient not using psr-17 factories #173

Closed

Description

@sunkan
Q A
Bug? yes
New Feature? yes
Version 2.0

Hi

Why dose HttpMethodsClient use Http\Message\RequestFactory instead of the psr-17 interfaces.

At the moment the only why to use HttpMethodsClient is to write wrapper classes around the psr-17 implementation.

Are there any plans to fix this?
I can put together a pull request if that's needed, but the problem is that this will be a bc break. So I don't know how you would like to solve this problem

Activity

  1. xabbuh commented on Jun 14, 2019

    @xabbuh
    Member

    Removing the type hint and then creating the request depending on the factory type should be possible, shouldn't it?

  2. GrahamCampbell commented on Jul 1, 2020

    @GrahamCampbell
    Contributor

    This has been fixed now, and can be closed. I would have reffed this issue in my PR (#190), had I seen it before!

    // cc @dbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions