[rutvik23]

Summary

• Updates API server documentation to include Modern among supported TLS profiles and VersionTLS13 as the maximum minTLSVersion.

• Removes the outdated shared statement that Modern is unsupported and
  updates generated API documentation and CRD manifests. No runtime or
  validation behavior changes.

• Fixes OCPBUGS-57313

Additional info

• Support for modern profile and TLS13 has been enabled via API-1854.
• release-4.20 already has Modern profile defined as valid type:
  https://github.com/openshift/api/blob/release-4.20/config/v1/types_tlssecurityprofile.go#L7

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

[openshift-ci-robot]

@rutvik23: This pull request references Jira Issue OCPBUGS-57313, which is invalid:

• expected the bug to target the "4.20.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-57313 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Updates API server documentation to include Modern among supported TLS
  profiles and VersionTLS13 as the maximum minTLSVersion.

• Removes the outdated shared statement that Modern is unsupported and
  updates generated API documentation and CRD manifests. No runtime or
  validation behavior changes.

• Fixes OCPBUGS-57313

Additional info

• Support for modern profile and TLS13 has been enabled via API-1854.
• release-4.20 already has Modern profile defined as valid type:
  https://github.com/openshift/api/blob/release-4.20/config/v1/types_tlssecurityprofile.go#L7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Central YAML; Path: .coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: fd23daba-3d3c-4b9c-9f24-4ece6b79fd6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

[openshift-ci]

Hello @rutvik23! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[everettraven]

/lgtm
/approve

[everettraven]

@rutvik23 Is this intentionally only targeting 4.20? Has this already been updated on all newer branches?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rutvik23]

@rutvik23 Is this intentionally only targeting 4.20? Has this already been updated on all newer branches?

@everettraven

• 4.22, 4.23, 5.0 looks good to me.
• In 4.21, types_apiserver.go looks fine, but the reference in types_tlssecurityprofile.go is still contradictory at this place.

Let me know how we should approach to fix it in 4.21.

[everettraven]

/label backport-risk-assessed
/label jira/valid-bug

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@rutvik23: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rutvik23]

@everettraven - please tag lgtm once again, I had to push for a nit change as I realized there's one more stale ref that need to be cleaned up - appreciate your patience.