Skip to content

OCPBUGS-57313: fix(api): Correct API server Modern TLS profile documentation #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rutvik23 wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

OCPBUGS-57313: fix(api): Correct API server Modern TLS profile documentation #3129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/v1/types_apiserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ type APIServerSpec struct {
// tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.
//
// If unset, a default (which may change between releases) is chosen. Note that only Old,
// Intermediate and Custom profiles are currently supported, and the maximum available
// minTLSVersion is VersionTLS12.
// Intermediate, Modern and Custom profiles are currently supported, and the maximum available
// minTLSVersion is VersionTLS13.
// +optional
TLSSecurityProfile *TLSSecurityProfile `json:"tlsSecurityProfile,omitempty"`
// audit specifies the settings for audit configuration to be applied to all OpenShift-provided
Expand Down
5 changes: 0 additions & 5 deletions config/v1/types_tlssecurityprofile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ type TLSSecurityProfile struct {
// are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
// reduced.
//
// Note that the Modern profile is currently not supported because it is not
// yet well adopted by common software libraries.
//
// +unionDiscriminator
// +optional
Type TLSProfileType `json:"type"`
Expand Down Expand Up @@ -219,8 +216,6 @@ type TLSProfileSpec struct {
//
// minTLSVersion: VersionTLS11
//
// NOTE: currently the highest minTLSVersion allowed is VersionTLS12
//
MinTLSVersion TLSProtocolVersion `json:"minTLSVersion"`
}

Expand Down
9 changes: 2 additions & 7 deletions ...zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -338,8 +338,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -483,9 +481,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
9 changes: 2 additions & 7 deletions config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -269,8 +269,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -414,9 +412,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
9 changes: 2 additions & 7 deletions ...enerated.crd-manifests/0000_10_config-operator_01_apiservers-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -338,8 +338,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -483,9 +481,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
9 changes: 2 additions & 7 deletions ...nerated.crd-manifests/0000_10_config-operator_01_apiservers-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -338,8 +338,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -483,9 +481,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
9 changes: 2 additions & 7 deletions ...1/zz_generated.featuregated-crd-manifests/apiservers.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -269,8 +269,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -414,9 +412,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
9 changes: 2 additions & 7 deletions ...ated.featuregated-crd-manifests/apiservers.config.openshift.io/KMSEncryptionProvider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ spec:
tlsSecurityProfile specifies settings for TLS connections for externally exposed servers.

If unset, a default (which may change between releases) is chosen. Note that only Old,
Intermediate and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS12.
Intermediate, Modern and Custom profiles are currently supported, and the maximum available
minTLSVersion is VersionTLS13.
properties:
custom:
description: |-
Expand Down Expand Up @@ -338,8 +338,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -483,9 +481,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
6 changes: 3 additions & 3 deletions config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions ...iguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -296,9 +294,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
5 changes: 0 additions & 5 deletions ...turegated-crd-manifests/kubeletconfigs.machineconfiguration.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ spec:
versions 1.1, 1.2 and 1.3 (yaml):

minTLSVersion: VersionTLS11

NOTE: currently the highest minTLSVersion allowed is VersionTLS12
enum:
- VersionTLS10
- VersionTLS11
Expand Down Expand Up @@ -297,9 +295,6 @@ spec:
The profiles are intent based, so they may change over time as new ciphers are developed and existing ciphers
are found to be insecure. Depending on precisely which ciphers are available to a process, the list may be
reduced.

Note that the Modern profile is currently not supported because it is not
yet well adopted by common software libraries.
enum:
- Old
- Intermediate
Expand Down
Loading