[JoelSpeed]

This PR runs kal -fix, which auto fixes based on several linter rules.

• Any usage of +kubebuilder:validation:Required is replaced with +required, all tooling now supports the latter
• Any usage of +kubebuilder:validation:Optional is replaced with +optional, all tooling as always supported the latter
• Any duplicating of upstream and kubebuilder optional/required tags is deduplicated
• Any comment that starts with the json tag name value, but does not match its casing, is updated (eg Foo -> foo)

This means that anyone who now sees linter errors, has a chance to run make lint-fix and have it fix only their issues, from their PR, rather than having it fix the who repository.

I've run the generation, and checked painstakingly, that there are no functional changes to the output of the generated CRDs. All that we have updated here, are markers, and documentation, to be consistent.

I hope to merge this quickly as the merge conflicts will be hell.

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[deads2k]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c1fdeb0 and 2 for PR HEAD 98b61ad in total

[theobarberbany]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c1fdeb0 and 2 for PR HEAD 30be263 in total

[JoelSpeed]

/retest-required

[openshift-ci]

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	00176d2	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[theobarberbany]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment