Repository navigation
fix(ci): use shell expansion to run test files - #761
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 37 37
Lines 4191 4191
=======================================
Hits 3476 3476
Misses 715 715 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Blocked on rvagg/ghauth#31 |
targos
approved these changes
Dec 8, 2023
targos
left a comment
targos
left a comment
Member
There was a problem hiding this comment.
SGTM assuming we don't want to support Windows.
Contributor
Author
|
Yeah not sure why the CI doesn't run on Windows. I think it should work on Windows as long as you're using Node.js 21+ to run the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #752