You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
not a good one.
I would try changing the command based on the node version,
we can also run node --test $(find . -name 'test/unit/**.js' | tr '\n' ' ') which will be compatible for all versions
It probably is, we should have probably thought about that - although this change was a semver major change, and was necessary since it made it possibe to run typescript tests or tests other then the default pattern
Major changes for a test runner built into the platform will always cause this problem; the only solution is to never have them, or, not have a test runner that’s built in.
Activity
targos commentedon Nov 13, 2023
@nodejs/test_runner Is there a way to execute the test runner with arguments that work in all supported Node.js versions?
targos commentedon Nov 26, 2023
@MoLow Do you know of a solution?
MoLow commentedon Nov 26, 2023
not a good one.
I would try changing the command based on the node version,
we can also run
node --test $(find . -name 'test/unit/**.js' | tr '\n' ' ')which will be compatible for all versionstargos commentedon Nov 27, 2023
This is unfortunate. Isn't it a big issue for adoption of the test runner by projects that want to support all release lines?
MoLow commentedon Nov 27, 2023
It probably is, we should have probably thought about that - although this change was a semver major change, and was necessary since it made it possibe to run typescript tests or tests other then the default pattern
aduh95 commentedon Nov 28, 2023
I guess we could backport it behind a
--experimental-glob-in-test-runnerflag or something like thatljharb commentedon Nov 28, 2023
Major changes for a test runner built into the platform will always cause this problem; the only solution is to never have them, or, not have a test runner that’s built in.