Repository navigation
LDP constructor cleanup - #705
Merged
Merged
Conversation
dmitrizagidulin
force-pushed
the
ldp-constructor-cleanup
branch
from
June 11, 2018 17:50
008816d to
859cb0e
Compare
RubenVerborgh
approved these changes
Jun 11, 2018
| if (!this.root.endsWith('/')) { this.root += '/' } | ||
|
|
||
| if (this.corsProxy && !this.corsProxy.startsWith('/')) { | ||
| this.corsProxy = '/' + this.corsProxy |
Contributor
There was a problem hiding this comment.
So the above is fine, but when I code, I tend to have the rule that the length of the code should represent the complexity of the action. My suggestion would be:
this.root.replace(/\/*$/, '/');
this.corsProxy.replace(/$\/*/, '/');
Contributor
Author
There was a problem hiding this comment.
Does the regex variant take care of the if (this.corsProxy && guard?
(I must admit, though I like the conciseness of regex, since i'm less familiar with it, I find the more wordy if/then more readable :) )
Contributor
There was a problem hiding this comment.
Ah no, doesn't have that guard. Leave it as-is then, readability is king.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extenddep (obsoleted by Object.assign)initErrorPages()out of LDP constructor(Part of ongoing PR #702)