Repository navigation
Expand SolidHost config constructor, plus tests - #1127
Conversation
kjetilk
left a comment
There was a problem hiding this comment.
Looks good to me, but I don't quite understand the impact of just passing argv, so I think there should be more reviews.
|
@kjetilk so, the impact of the change (just passing in the |
There was a problem hiding this comment.
LGTM, assuming that there will then be other code that reads these new variables (host.live, host.root, host.multiuser, host.webid). Is this adding them as runtime configurable (as opposed to read from the config)? If so, then they should also be added to the usage documentation somewhere, probably?
|
@michielbdejong Yes, there is downstream code that checks those params. (And no, they're not live-configurable, they're just from the config file only) |
Minor refactor, expand the
SolidHostconstructor.Extracted from PR #702, partly addresses issue #483.