Repository navigation
Fix code lens bug + added some tests - #6782
Conversation
c1e953c to
61a0a39
Compare
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
What is different from #6755? Is it only that you are no longer ignoring roots that do not match the current workspace? Why did you remove that part?
(otherwise looks good)
Eric Snow (@ericsnowcurrently) Yes, current workspace path is not related to data root paths at all. Because test root paths can be anything, as you explained. So removed that entire check, where I was only considering data roots which are equal to workspace root. |
|
We should still ensure that the test root is under the workspace folder, even if it isn't equal. |
|
Eric Snow (@ericsnowcurrently) But that seems unrelated to this issue, right? Would prefer to do it separately if that's the case. Also, even if tests are outside the workspace, why not discover those tests as well? |
|
I've opened #6820 for dealing with the test roots. |
For #6303
This is effectively an un-revert of #6755 (reverted in #6780), with testing fixes.
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.