Skip to content

Fix code lens bug - #6755

Merged
Kartik Raj (karrtikr) merged 6 commits into
microsoft:masterfrom
karrtikr:fixcodelens
Jul 30, 2019
Merged

Kartik Raj (karrtikr) merged 6 commits into
microsoft:masterfrom
karrtikr:fixcodelens

Conversation

@karrtikr

@karrtikr Kartik Raj (karrtikr) commented Jul 29, 2019 •

Copy link
Copy Markdown

For #6303

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@karrtikr Kartik Raj (karrtikr) changed the title Do not normalize path in adapter + Fix code lens bug Fix code lens bug Jul 30, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests tests tests

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty close. There are only a few small things to address.

Comment thread news/2 Fixes/6303.md Resolved

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for those changes!

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants