Repository navigation
Fix code lens bug - #6755
Merged
Merged
Fix code lens bug#6755
Conversation
Kartik Raj (karrtikr)
force-pushed
the
fixcodelens
branch
from
July 30, 2019 00:15
267edd8 to
c06b7f4
Compare
Don Jayamanne (DonJayamanne)
previously requested changes
Jul 30, 2019
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Tests tests tests
Eric Snow (ericsnowcurrently)
suggested changes
Jul 30, 2019
Kartik Raj (karrtikr)
force-pushed
the
fixcodelens
branch
from
July 30, 2019 19:41
837d191 to
4fc5000
Compare
Kartik Raj (karrtikr)
requested review from
Don Jayamanne (DonJayamanne) and
Eric Snow (ericsnowcurrently)
July 30, 2019 19:41
Eric Snow (ericsnowcurrently)
suggested changes
Jul 30, 2019
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
This is pretty close. There are only a few small things to address.
Eric Snow (ericsnowcurrently)
approved these changes
Jul 30, 2019
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
LGTM
Thanks for those changes!
Kartik Raj (karrtikr)
dismissed
Don Jayamanne (DonJayamanne)’s stale review
July 30, 2019 21:41
Addressed
Kartik Raj (karrtikr)
pushed a commit
that referenced
this pull request
Jul 30, 2019
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6303
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.