You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Folder in file explorer cannot be expanded (Send unnormalized file paths from the pytest adapter) #6758
The extension code expects adapter to return unnormalized file paths, but the adapter is returning after normalizing paths.
This causes a problem in windows. Consider the following file path sent from the adapter. c:\users\user\documents\test-venv\tests\test_a.py
The actual file path is c:\Users\User\Documents\test-venv\Tests\test_a.py
Path sent by adapter: C:\Users\karraj\Desktop\Desktop\test_demo\tests\test_4.py
Expected path: C:\Users\karraj\Desktop\Desktop\test_demo\Tests\test_4.py
It looks like data.root is sent correctly, but data.parents (which carries the relative file path to the root) is normalized.
Kartik Raj (@karrtikr), I'm not sure what the problem might be here. I cannot reproduce any failures. I've even added a functional tests to ensure filenames are not normcased (see #6856) and they are passing on Windows in CI. Note that I did not have to change any code for that, so it shouldn't have been a problem for you.
Activity
ericsnowcurrently commentedon Jul 31, 2019
As noted in #6303 (comment), we still need to be sure to not make unwarranted assumptions in the extension.
karrtikr commentedon Jul 31, 2019
While validating it, please make sure it fixes issues like #6789 #6554.
2 remaining items
DonJayamanne commentedon Aug 4, 2019
Updated title, else the severity of the issue is unknown
karrtikr commentedon Aug 5, 2019
Path sent by adapter:
C:\Users\karraj\Desktop\Desktop\test_demo\tests\test_4.pyExpected path:
C:\Users\karraj\Desktop\Desktop\test_demo\Tests\test_4.pyIt looks like
data.rootis sent correctly, butdata.parents(which carries the relative file path to the root) is normalized.ericsnowcurrently commentedon Aug 5, 2019
Kartik Raj (@karrtikr), I'm not sure what the problem might be here. I cannot reproduce any failures. I've even added a functional tests to ensure filenames are not normcased (see #6856) and they are passing on Windows in CI. Note that I did not have to change any code for that, so it shouldn't have been a problem for you.
Make sure filenames are not norm-cased on Windows. (#6856)
Send "relpath" back for all test files/folders. (#6877)
ericsnowcurrently commentedon Aug 9, 2019
Kartik Raj (@karrtikr), please validate this again. Thanks!
We can talk about Monday if you find any problems.
karrtikr commentedon Aug 9, 2019
Validated
Fix failing functional extension tests in CI related to pytest discov…