Skip to content

Folder in file explorer cannot be expanded (Send unnormalized file paths from the pytest adapter) #6758

Closed

Description

@karrtikr

The extension code expects adapter to return unnormalized file paths, but the adapter is returning after normalizing paths.

This causes a problem in windows. Consider the following file path sent from the adapter.
c:\users\user\documents\test-venv\tests\test_a.py
The actual file path is c:\Users\User\Documents\test-venv\Tests\test_a.py

Activity

  1. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Jul 30, 2019
  2. ericsnowcurrently commented on Jul 31, 2019

    @ericsnowcurrently

    As noted in #6303 (comment), we still need to be sure to not make unwarranted assumptions in the extension.

  3. karrtikr commented on Jul 31, 2019

    @karrtikr
    Author

    While validating it, please make sure it fixes issues like #6789 #6554.

  4. 2 remaining items

  5. DonJayamanne commented on Aug 4, 2019

    @DonJayamanne

    Updated title, else the severity of the issue is unknown

  6. karrtikr commented on Aug 5, 2019

    @karrtikr
    Author

    Path sent by adapter: C:\Users\karraj\Desktop\Desktop\test_demo\tests\test_4.py
    Expected path: C:\Users\karraj\Desktop\Desktop\test_demo\Tests\test_4.py

    It looks like data.root is sent correctly, but data.parents (which carries the relative file path to the root) is normalized.

  7. removed their assignment
    on Aug 5, 2019
  8. ericsnowcurrently commented on Aug 5, 2019

    @ericsnowcurrently

    Kartik Raj (@karrtikr), I'm not sure what the problem might be here. I cannot reproduce any failures. I've even added a functional tests to ensure filenames are not normcased (see #6856) and they are passing on Windows in CI. Note that I did not have to change any code for that, so it shouldn't have been a problem for you.

  9. ericsnowcurrently commented on Aug 9, 2019

    @ericsnowcurrently

    Kartik Raj (@karrtikr), please validate this again. Thanks!

    We can talk about Monday if you find any problems.

  10. karrtikr commented on Aug 9, 2019

    @karrtikr
    Author

    Validated

  11. ghost removed on Aug 9, 2019
  12. locked as resolved and limited conversation to collaborators on Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-testingbugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityregressionBug didn't exist in a previous release

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions