Repository navigation
Guard tests against tracked file changes - #2308
tamirdresher merged 4 commits into
Conversation
🟡 Impact Analysis — PR #2308Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
tests (17 files)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 4 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 9 check(s) still running |
Files Changed (18 files, +181 −33)
| File | +/− |
|---|---|
test/acceptance/acceptance.test.ts |
+2 −2 |
test/acceptance/features/init-command.feature |
+4 −3 |
test/acceptance/steps/cli-steps.ts |
+28 −3 |
test/casting-legacy-migration.test.ts |
+2 −1 |
test/casting.test.ts |
+2 −1 |
test/cli-packaging-smoke.test.ts |
+6 −0 |
test/cli.test.ts |
+4 −6 |
test/cli/cast.test.ts |
+5 −2 |
test/cli/legacy-casting-upgrade.test.ts |
+3 −2 |
test/cli/state-mcp-lifecycle.test.ts |
+2 −1 |
test/init.test.ts |
+4 −7 |
test/memory-governance.test.ts |
+2 −1 |
test/memory-providers.test.ts |
+2 −1 |
test/presets.test.ts |
+2 −2 |
test/setup/tracked-worktree-guard.ts |
+57 −0 |
test/speed-gates.test.ts |
+2 −1 |
test/tracked-worktree-guard.test.ts |
+53 −0 |
vitest.config.ts |
+1 −0 |
Total: +181 −33
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
9891ae8 to
02d8ee3
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
02d8ee3 to
4c9a144
Compare
|
Thanks Omer, great detective work tracking down the second working tree writer to est/acceptance/features/init-command.feature running squad init in process.cwd() and cleaning up the remaining process.cwd() test sandboxes. I verified the merge-tree against dev is clean and the �itest.config.ts global setup snapshot guard in est/setup/tracked-worktree-guard.ts is a solid systemic fix for #1807. dev is currently frozen for 2.0.0-preview.2, so we will merge this right after the release ships, early in the queue right behind #2306. |
|
Thanks for tracing the remaining test writers and checking the merge. Glad the snapshot guard closes the gap. Appreciate the queue update; I will leave the PR as-is through the freeze. |
Closes #1807
Adds a Vitest global setup guard that snapshots tracked files before the suite and fails with the changed paths if tests mutate the checkout. CRLF-only differences are ignored. Moves the legacy casting upgrade fixture into the OS temp directory so it cannot write test repositories under the project root.
Verified with the focused guard and legacy upgrade tests (16 passing), build, and lint.