Repository navigation
Accept mixed-case reconciliation commands - #2306
tamirdresher merged 3 commits into
Conversation
🟡 Impact Analysis — PR #2306Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (2 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 14 check(s) still running |
Files Changed (3 files, +48 −2)
| File | +/− |
|---|---|
test/gh-aw-command-parse.test.ts |
+45 −0 |
workflows/shared/squad-command-contract.mjs |
+2 −1 |
workflows/squad-workflows.manifest.json |
+1 −1 |
Total: +48 −2
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
55f8566 to
86fdb5c
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
86fdb5c to
aac066a
Compare
|
Thanks Omer! I verified this against dev (merge-tree is clean) and confirmed the case mismatch in workflows/shared/squad-command-contract.mjs:180. Good call keeping the strict lowercase 64-hex SHA check, positive request ID validation, and updated manifest hash intact. We are in a release freeze for 2.0.0-preview.2 right now and will merge this first in the queue right after the release goes out. |
|
Thanks for verifying the merge and the stricter validation. Appreciate you putting this first after the preview ships. |
Closes #2205
Reconciliation now accepts mixed-case command words without changing the strict lowercase SHA and positive request ID checks. Added parser cases for comment and workflow dispatch, invalid hashes and IDs, authorization, and casing-only comment edits.
Checked: 12 focused reconciliation tests, build, type lint, ESLint, and node --check. The full command-parser suite has one Windows CRLF-only workflow text assertion failure; the authorization suite cannot load here because the pinned gh-aw compiler is unavailable. Neither failure is in the changed parser path.