Skip to content

Accept mixed-case reconciliation commands - #2306

Merged
tamirdresher merged 3 commits into
github:devfrom
omercangumus:omercangumus/2205-reconcile-command-case
Oct 26, 2026
Merged

tamirdresher merged 3 commits into
github:devfrom
omercangumus:omercangumus/2205-reconcile-command-case

Conversation

@omercangumus

Copy link
Copy Markdown
Contributor

Closes #2205

Reconciliation now accepts mixed-case command words without changing the strict lowercase SHA and positive request ID checks. Added parser cases for comment and workflow dispatch, invalid hashes and IDs, authorization, and casing-only comment edits.

Checked: 12 focused reconciliation tests, build, type lint, ESLint, and node --check. The full command-parser suite has one Windows CRLF-only workflow text assertion failure; the authorization suite cannot load here because the pinned gh-aw compiler is unavailable. Neither failure is in the changed parser path.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2306

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 3
Files added 0
Files modified 3
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 3 files changed (≤5 → LOW)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (2 files)
  • workflows/shared/squad-command-contract.mjs
  • workflows/squad-workflows.manifest.json
tests (1 file)
  • test/gh-aw-command-parse.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit c704620

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 14 check(s) still running

Files Changed (3 files, +48 −2)

File +/−
test/gh-aw-command-parse.test.ts +45 −0
workflows/shared/squad-command-contract.mjs +2 −1
workflows/squad-workflows.manifest.json +1 −1

Total: +48 −2


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@omercangumus
omercangumus force-pushed the omercangumus/2205-reconcile-command-case branch from 55f8566 to 86fdb5c Compare October 24, 2026 13:58
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@omercangumus
omercangumus force-pushed the omercangumus/2205-reconcile-command-case branch from 86fdb5c to aac066a Compare October 24, 2026 14:07
@omercangumus
omercangumus marked this pull request as ready for review October 24, 2026 14:14
@tamirdresher

Copy link
Copy Markdown
Collaborator

Thanks Omer! I verified this against dev (merge-tree is clean) and confirmed the case mismatch in workflows/shared/squad-command-contract.mjs:180. Good call keeping the strict lowercase 64-hex SHA check, positive request ID validation, and updated manifest hash intact. We are in a release freeze for 2.0.0-preview.2 right now and will merge this first in the queue right after the release goes out.

@omercangumus

Copy link
Copy Markdown
Contributor Author

Thanks for verifying the merge and the stricter validation. Appreciate you putting this first after the preview ships.

@tamirdresher
tamirdresher merged commit 8134af6 into github:dev Oct 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Normalize reconciliation command keyword casing without relaxing SHA validation

2 participants