Repository navigation
fix(writer): a numeric column keeps its dict layout past 2,048 distinct values (#649) - #682
Merged
Merged
Conversation
…ct values, one dictionary after another (#649) Rust's DictStrategy admits a column when its probe compressor, the cascade, turns the first 8192 rows into a dict, and closes the open dictionary at 65,535 entries or 1 MiB (the primitive builder's max_len and max_bytes / byte width) to start the next. Java admitted a numeric column only with at most 2,048 distinct values, under half distinct, in one dictionary demoted to per-chunk encoding past the cap, so hash-like columns (ClickBench RefererHash, URLHash) were written plain, twice the size. Numeric columns now take the same prefix-consuming ingest as text: the first entry is always admitted, the row that needs an entry that no longer fits (a value or the null entry) ends the dictionary, and the writer chunks the dict layouts. Admission is Rust's probe for every nullable or non-null column of a type the layout reads; with cascading(0) there is no cascade, so the sample's distinct count decides. The interop test compares the dict-layout count with vortex-jni for pools of 100 to 150000 i64 values. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649.
cascading(0)has no cascade to probe, so the sample's distinct count decides (under half, more than one).Builds on the text flow merged in #679. Decimal columns (#662) are separate.
🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV