Repository navigation
fix(writer): a text column starts a new dictionary instead of giving up its dict layout (#650) - #679
Merged
Merged
Conversation
dfa1
force-pushed
the
feat/583-utf8-varbinview
branch
from
November 6, 2026 20:35
b8b840b to
358dda5
Compare
dfa1
force-pushed
the
fix/650-string-dict-layout
branch
from
November 6, 2026 20:43
154caaf to
d699906
Compare
…up its dict layout (#650) Rust's dict layout admits a text column by its first 8192 rows (not more than half distinct) and, when the open dictionary reaches 65,535 entries or 1 MiB, closes it and starts another (DictStrategy, DictLayoutConstraints). Java capped the whole column at 32,768 distinct values in its first batch and demoted it to per-chunk dictionaries beyond, so columns with locality (URLs, titles, referers) lost the shared dictionaries and their bare bit-packed codes. A text column now keeps a list of dictionaries, each filled to Rust's constraints (first entry always admitted, the row needing an entry that no longer fits starts the next dictionary) and written as a chunked layout of dict layouts. Admission looks at the first 8192 rows, as Rust does. The interop test compares the number of dict layouts with vortex-jni for pools of 100 to 150000 values, and for a sliding window that fills two dictionaries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
dfa1
force-pushed
the
fix/650-string-dict-layout
branch
from
November 6, 2026 20:57
d699906 to
c2895e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #677. Fixes the layout half of #650.
Rust's
DictStrategyadmits a text column by its first 8192 rows (not more than half distinct) and closes the open dictionary at 65,535 entries or 1 MiB, starting another. Java capped the column at 32,768 distinct values in its first batch and demoted it to per-chunk dictionaries beyond.DictColumnState.ingestVarBinChunkingests the prefix that fits Rust's constraints (first entry always admitted); the writer keeps a list of dictionaries per column and writes a chunked layout of dict layouts.Not covered: nullable text still goes through
masked(dict)per chunk when the layout is not admitted (the other half of the issue'sbi-genericorows), and the OnPair/FSST choice inside the values.🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV