Repository navigation
List the shape inventory per name order (3.0, 4h) - #974
Merged
Merged
Conversation
tools/differential/shapes.py gains ARRANGEMENTS: the written arrangements each order is read in (a title at the front, between the family and the given name and at the end; a suffix without, before and after a comma; the four comma shapes; a middle, a particle, a nickname), each pinned to what the tree reads today. Six rows, the title between or bare after the family under a family-first order, are marked misread for #938, which decides them; their readings are recorded, not changed. A shape stays one skeleton per order and comma family, so the corpus tag, _shape_for and compare.py's min_baseline skip are untouched. tests/v2/test_shape_inventory.py reads every row under its order and holds each order to cover every position it has a slot for. The arrangements join corpus_shapes.jsonl; the snapshot gains 45 entries and no existing reading moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The family-first orders have one shape for every comma family, so their family-comma rows carry the order, not the notation's comma (shapes.py docstring, the entry). The bare trailing title is H5's stated reading, not a cost, and `van Gogh Vincent` under FAMILY_FIRST is held by no rule's statement, now listed as unweighed. usage.rst keeps form 1's credential exception for a bare trailing title, and the RFC row narrows the misread rows to the title between and bare after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#938 is declined on a survey of real family-first names, which write the title in front (decisions/H5's 2026-10-30 #938 entry, with the measurement), so its rows are accepted readings rather than misread ones. A row now carries `accepted` (the document deciding its reading) or `misread` (an open issue), and the kinds it reports; the test pins both, checks each position the text can show, and holds each mark to a file that exists. The inventory gains 40 rows across the three orders for nameparser/AGENTS.md's sweep items (a nickname-only head, connective and particle surnames before a comma, title-particles at the head, a dual in a title run, a trailing title after an empty head, a title after a full head's comma, a numeral, dotted and undotted suffixes, a period-shape title, an NFD letter), each with its current reading. The snapshot gains 35 more entries and no reading moves. The Hungarian `-né dr.` shape is recorded as Open for a future hu pack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The second review found that a row's positions were checked against its text only for a comma, so a mislabelled row still counted as coverage. Every position now has a vocabulary-read text predicate (a roman-numeral word, a one-word head counted as rules/C3 counts, an abbreviation shape the vocabulary does not list, and so on), and both reviewer mutations now fail. Vega y Lopez, Juan is relabelled a full head by that count. A mark is a decisions key only: the default Vega y Lopez Jr. row is accepted by decisions/C1's #613 entry, and the rows no decision weighs (van Gogh Vincent, du Ménil Thi Mai, the family-first Vega rows) carry none and are listed as unweighed. decisions/H5's #938 entry gains a Recompute recipe in place of the untracked survey citation; the RFC's shapes passage and render note and decisions/vocabulary-model's render entry state the decline. The negative control is re-taken on the final grid (49 of 68) beside the first grid's (31 of 40). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-phase 4h of #754: the shape inventory per order (#469). This lists the written arrangements each
name_orderis read in, each with what the tree reads today. No reading moves. It also records #938 as declined, decided in chat on a survey of real family-first names.What changes
tools/differential/shapes.pygainsARRANGEMENTS. It has 104 rows: 36 under the default order, 38 underFAMILY_FIRSTand 30 underFAMILY_FIRST_GIVEN_LAST. Each row has:accepted(the document that decided the reading) ormisread(an open issue).POSITIONScovers these, for every order:Shape, and each arrangement names the shape it is written under, inheriting its order andmin_baseline. That leaves the corpus tag,build_conventions_corpus._shape_for,cases._SHAPE_IDSand compare.py's skip untouched. Under a family-first order, family-comma rows are tagged 4 or 5 for their order, and theshapes.pydocstring says so.tests/v2/test_shape_inventory.pychecks:nfdneeds a text that NFC changes);corpus_shapes.jsonlgrows from 300 to 395 lines. The snapshot gains 80 entries and changes none.#938 declined
The decision is recorded in decisions/H5's (the trailing title run) 2026-10-30 #938 entry, with the survey figures and their dates and samples. Real family-first names write the title in front:
CLDR's 50 of 70 is a template artefact.
The eight rows in #938's shapes are now
accepted = "H5", as isJohn Smith Prof:Wang Dr. Xiaoming·Wang Dr Xiaoming·Wang Insp. XiaomingXiaomingBrühl Prof. Dr. Ada CorneliaProf., middleDr. Ada CorneliaWang Xiaoming SenatorSenatorNguyen Dr. Thi Mai·Nguyen Insp. Thi MaiDr. Thi·Insp. ThiNguyen Thi Mai SenatorSenator, middleThi MaiThe usage.rst paragraph after forms 4 and 5 now states the title-in-front convention as the supported reading.
Open, in the 4h entry:
-néword (Bakainé dr. Korbács Melinda): 102 of 37,250 names, all misread today. It is a question for a futurehupack.Vega y Lopez Jr., PhD Jonesunder the family-first orders (givenyorLopez), and an ambiguous particle opening a family-first name (van Gogh Vincentreads familyvan).Checks
uv run pytest: 33,883 passed.-n0 -m serial: 42 passed.sphinx-build -b doctestis clean.van Gogh Vincent,du Ménil Thi Maiand the family-firstVegarows are unmarked and listed as unweighed, and the defaultVegarow isaccepted="C1";🤖 Generated with Claude Code