Skip to content

StorageManager tech debt 5/6: trivial warnings - #14562

Open
DaanHoogland wants to merge 1 commit into
ghi12316-storage-unused-paramsfrom
ghi12316-storage-trivial-warnings
Open

DaanHoogland wants to merge 1 commit into
ghi12316-storage-unused-paramsfrom
ghi12316-storage-trivial-warnings

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #14561

Description

Stack for #12316 (StorageManager tech debt), one PR per item of the issue checklist, review only the top commit of each:

  1. StorageManager tech debt 1/6: remove unused methods, fields and return values #13598: unused methods, fields and return values
  2. never-thrown checked exceptions
  3. raw types and unchecked casts
  4. never-used parameters
  5. remaining trivial warnings
  6. deprecated SearchCriteria.addAnd usages

This PR (5/6) handles the remaining trivial warnings in StorageManagerImpl and the storage commands:

  • parameterised logging instead of String.format and string concatenation
  • isEmpty() and CollectionUtils instead of size() > 0, and simplified boolean and redundant-initialiser code
  • removes redundant logger.isDebugEnabled() guards around parameterised calls. Guards that protect eagerly computed toHumanReadableSize() arguments stay.
  • drops required = false (the default) and reformats long @Parameter annotations

The SearchCriteria.addAnd deprecations follow in 6/6. The Config deprecation warnings are left to #10752 / #14467.

Part of #12316

Types of changes

  • Cleanup (Code refactoring and cleanup, that may add test cases)

🤖 Generated with Claude Code

Part of #12316

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DaanHoogland
DaanHoogland added this pull request to stack #14563 November 2, 2026 14:31
@DaanHoogland DaanHoogland linked an issue Nov 2, 2026 that may be closed by this pull request
7 tasks done
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.88%. Comparing base (c5422ae) to head (974b403).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           ghi12316-storage-unused-params   #14562   +/-   ##
===============================================================
  Coverage                            3.88%    3.88%           
===============================================================
  Files                                 493      493           
  Lines                               42571    42571           
  Branches                             8069     8069           
===============================================================
  Hits                                 1653     1653           
  Misses                              40687    40687           
  Partials                              231      231           
Flag Coverage Δ
uitests 3.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland changed the title StorageManager tech debt 5/5: trivial warnings StorageManager tech debt 5/6: trivial warnings Nov 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deal with tech debt in StorageManager(Impl)

1 participant