[DaanHoogland]

Depends on #14560

Description

Stack for #12316 (StorageManager tech debt), one PR per item of the issue checklist, review only the top commit of each:

1. StorageManager tech debt 1/6: remove unused methods, fields and return values #13598: unused methods, fields and return values
2. never-thrown checked exceptions
3. raw types and unchecked casts
4. never-used parameters
5. remaining trivial warnings
6. deprecated SearchCriteria.addAnd usages

This PR (4/6) removes never-used parameters from non-framework methods:

• StorageManager.cleanupStorage(boolean recurring) → cleanupStorage() (callers: StorageManagerImpl, GarbageCollectingStoragePoolAllocator)
• cleanupSecondaryStorage(boolean recurring) → cleanupSecondaryStorage()
• removes the stubs sendToPool(long poolId, Command) and sendToPool(long poolId, Commands), which ignored both parameters, returned null and had no callers (every caller uses the StoragePool overloads)

The remaining unused parameters belong to framework contracts (configure, ClusterManagerListener) and stay.

Part of #12316

Types of changes

• Cleanup (Code refactoring and cleanup, that may add test cases)

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ghi12316-storage-rawtypes@9523aad). Learn more about missing BASE report.

Additional details and impacted files

@@                     Coverage Diff                      @@
##             ghi12316-storage-rawtypes   #14561   +/-   ##
============================================================
  Coverage                             ?    3.88%           
============================================================
  Files                                ?      493           
  Lines                                ?    42571           
  Branches                             ?     8069           
============================================================
  Hits                                 ?     1653           
  Misses                               ?    40687           
  Partials                             ?      231           

Flag	Coverage Δ
uitests	3.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.