Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

test(ngClass) added a ngOdd/Even sort test which uses the orderBy filter - #1613

Closed
rgaskill wants to merge 1 commit into
angular:masterfrom
rgaskill:ngclass_orderby_test
Closed

rgaskill wants to merge 1 commit into
angular:masterfrom
rgaskill:ngclass_orderby_test

Conversation

@rgaskill

Copy link
Copy Markdown

The existing sort test does not use the orderBy filter to change the order of the rows.

@pkozlowski-opensource

Copy link
Copy Markdown
Member

@rgaskill this is a bit of integration test as it involves a filter. I will let @IgorMinar decide.

@IgorMinar

Copy link
Copy Markdown
Contributor

I applied 933c683 to master and it passes. I believe that the issue was closed by d859dce

@IgorMinar IgorMinar closed this Nov 28, 2012
@rgaskill

Copy link
Copy Markdown
Author

@IgorMinar yes the original issue was fixed by d859dce. This pull request was to just add the test to master. This test identifies the original problem. The current set of tests do not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants