You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
ngClassOdd/Even doesn't work when reversing orderBy filter #1563
@rgaskill I think that @IgorMinar added tests for this but if you find anything not covered with tests please open a separate PR with tests only. Thnx once again for the bug report and the PR, it helped to see the real problem and brainstorm different solutions.
@pkozlowski-opensource I have created PR: #1613. It appears to me the problem was fixed once before #1076 but then it broke again. The tests originally added with #1076 didn't catch the break because the sort test didn't use the orderBy filter. This new test does.
Thank you for all the work is being done to keep this project moving forward!
@IgorMinar It is fixed in master and works OK. It is just that @rgaskill opened #1613 with an additional test. I was pinging you to see if this test is needed or maybe the functionality is already covered by other tests.
Activity
jtymes commentedon Nov 13, 2012
Just want to note for others that this is related to #1519
Something is clearly broken with these directives.
pkozlowski-opensource commentedon Nov 27, 2012
@rgaskill It was fixed in the latest version of AngularJS (1.0.3 / 1.1.1) through this PR:
#1602
Working plunk here: http://plnkr.co/edit/R1Zpzt?p=preview
pkozlowski-opensource commentedon Nov 27, 2012
BTW: nice way of exposing a bug by attaching test!
rgaskill commentedon Nov 27, 2012
Thanks Shouldn't the test get pulled into the project?
pkozlowski-opensource commentedon Nov 27, 2012
@rgaskill I think that @IgorMinar added tests for this but if you find anything not covered with tests please open a separate PR with tests only. Thnx once again for the bug report and the PR, it helped to see the real problem and brainstorm different solutions.
rgaskill commentedon Nov 27, 2012
@pkozlowski-opensource I have created PR: #1613. It appears to me the problem was fixed once before #1076 but then it broke again. The tests originally added with #1076 didn't catch the break because the sort test didn't use the orderBy filter. This new test does.
Thank you for all the work is being done to keep this project moving forward!
IgorMinar commentedon Nov 28, 2012
Isn't this fixed in master?
pkozlowski-opensource commentedon Nov 28, 2012
@IgorMinar It is fixed in master and works OK. It is just that @rgaskill opened #1613 with an additional test. I was pinging you to see if this test is needed or maybe the functionality is already covered by other tests.