Repository navigation
Conversation
Release Dev and Publish Release now copy the SHA-tagged images from the CI registry (ghcr.io/<owner>/openshell) to quay.io/ai-openshell instead of retagging them in ghcr.io/nvidia/openshell. Stable archives are pushed to Quay directly. Jobs log in to Quay through the org's quay-login action with the job's OIDC token, so they run in the release environment. Dev also pushes the SHA tag so the 0.0.0-dev.<sha> chart resolves, and dev and prerelease promotions verify the SBOM on the Quay copy. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5807.docs.buildwithfern.com/openshell |
4 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases stop publishing to
ghcr.io/nvidia/openshell, which is frozen after the move toai-openshell/openshell. Release Dev and Publish Release now copy the SHA-tagged CI images toquay.io/ai-openshell/{gateway,sandbox,supervisor}, logging in with the job's OIDC token and no stored secret.Draft until the repository has moved to
ai-openshelland thereleaseenvironment exists. Before that, the Quay login has no valid OIDC subject to match.Related Issue
Refs #4554
Changes
ghcr.io/${GITHUB_REPOSITORY_OWNER,,}/openshell/<component>:<sha>to Quay as both:<sha>and:dev. The:<sha>tag backs the0.0.0-dev.<sha>chart, whoseappVersionis that SHA.quay.io/ai-openshell/<component>:<version>.latestis retagged within Quay.verify-image-sbom.sh --require-cargoagainst the Quay tag users pull, for dev, prerelease and stable.environment: releasewithid-token: write, andpackagesdrops toread, which is enough to read the CI registry. They log in throughai-openshell/workflows/quay-login, pinned to the commitai-openshell/consoleuses, asai-openshell+openshell_release.tag-ghcr-devandtag-ghcr-releasekeep their IDs; only their display names change. This keeps theneedslists and the publication check unchanged, and keeps the diff to promotion and login lines so it rebases cleanly with the runner changes.Setup this needs (outside the repo)
ai-openshell+openshell_releasewith Write ongateway,sandbox,supervisor,charts/openshellandcharts/openshell-workspace.https://token.actions.githubusercontent.com, expected subjectrepo:ai-openshell@311201172/openshell@1166129534:environment:release. This is the ID-based format measured on a test repo transferred intoai-openshell. Confirm it from a real run once this repository has moved.releasewith no required reviewers, because Release Dev runs on every push tomain. Its deployment policy has to admitmain,release/*andv*tags.Testing
Cross-registry copy: I copied the published
ghcr.io/nvidia/openshell/gateway:devto a local registry with the samedocker buildx imagetools create --prefer-index=falsecommand. The copy has the same index digest, keeps provenance for linux/amd64 and linux/arm64, and passestasks/scripts/verify-image-sbom.sh --require-cargo(SPDX=2, Cargo=1027).Overwrite guard: against the empty Quay repo,
skopeo inspectreturnsmanifest unknown, which is what the stable guard checks for.Lints:
actionlintpasses on the changed workflows, andzizmorreports no findings that aren't already onmain.Not verified: the Quay OIDC exchange, and whether Quay accepts the attestation manifests on push. Both need the moved repository; a dev release after the transfer covers them.
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Checklist