Repository navigation
Conversation
87ddc89 to
2dbc437
Compare
2dbc437 to
3123e8d
Compare
|
This branch does not yet include 2ed8cec ( |
3123e8d to
4bdcc9e
Compare
|
Label |
4bdcc9e to
05ee531
Compare
05ee531 to
c4db82b
Compare
c4db82b to
964436e
Compare
| @@ -22,6 +22,12 @@ pub const MIN_ROUTE_HANDLE_LEN: usize = 16; | |||
| /// Longest accepted route handle, in bytes. | |||
| pub const MAX_ROUTE_HANDLE_LEN: usize = 64; | |||
|
|
|||
| /// Generate a fresh opaque route handle for one runtime generation. | |||
| #[must_use] | |||
| pub fn new_route_handle() -> String { | |||
There was a problem hiding this comment.
This leaves two copies of new_route_handle. Could sandbox-backend/runtime_routed.rs re-export this one like it does validate_route_handle, and drop its own copy?
| openshell-core = { path = "../openshell-core", default-features = false, features = ["jwt", "otel", "clap"] } | ||
| openshell-isolation-interface = { path = "../openshell-isolation-interface" } | ||
| openshell-sandbox-backend = { path = "../openshell-sandbox-backend" } | ||
| openshell-core = { path = "../openshell-core", default-features = false } |
There was a problem hiding this comment.
Core drops jwt/otel/clap here. Intended? Works today since the SDK enables them.
| pub fn capabilities(&self) -> Result<GetCapabilitiesResponse, String> { | ||
| Ok(GetCapabilitiesResponse { | ||
| resource_admission_policy: openshell_core::resource_admission::DriverAdmissionConfig { | ||
| resource_admission_policy: openshell_driver_sdk::resource_admission::DriverAdmissionConfig { |
There was a problem hiding this comment.
nit: a few use lines would shorten these long openshell_driver_sdk::... paths.
964436e to
1b2fdc6
Compare
1b2fdc6 to
f099a71
Compare
f099a71 to
49cd255
Compare
Repoint the Kubernetes driver at openshell-driver-sdk and openshell-driver-contract and drop its direct openshell-isolation-interface, openshell-sandbox-backend and openshell-policy dependencies. Add new_route_handle next to validate_route_handle in the contract crate. openshell-core stays only for AppListenerConfig and DynamicStringAllowlist. Part of #5456 Signed-off-by: Evan Lezar <elezar@nvidia.com>
49cd255 to
f48c382
Compare
Summary
Move the in-tree Kubernetes driver onto
openshell-driver-sdkandopenshell-driver-contract. Only imports and Cargo dependencies change; there is no behaviour change.Related Issue
Part of #5456. Stacked on #5519 (base is
feat/5456-write-driver-contract-files/elezar); the launch credentials change (#5510) is stacked on this one because both touch the Kubernetes driver. Retarget as the PRs below merge.Changes
openshell-isolation-interface,openshell-sandbox-backendandopenshell-policydependencies.new_route_handlenext tovalidate_route_handlein the contract crate.openshell-corestays a direct dependency only forAppListenerConfigandDynamicStringAllowlist. It andopenshell-sandbox-backendremain in the driver's tree throughopenshell-supervisor-control.Release Notes
None.
Testing
rust:deny:policy,buf lintandbuf breakingpass at this tip. Theopenshell-driver-vmtests were not run to completion: they needmke2fs, which was unavailable locally.Checklist
ubuntu-k3send-to-end environment was not run; the change touches only imports and dependencies.