Repository navigation
Conversation
github-actions
Bot
requested review from
FrostGod,
drew,
mrunalp and
russellb
November 12, 2026 15:26
elezar
force-pushed
the
feat/5456-write-driver-contract-files/elezar
branch
from
November 13, 2026 12:52
d282977 to
3725213
Compare
elezar
force-pushed
the
feat/5456-write-driver-contract-files/elezar
branch
from
November 13, 2026 13:07
3725213 to
44f01ed
Compare
|
Label |
elezar
force-pushed
the
feat/5456-write-driver-contract-files/elezar
branch
from
November 13, 2026 13:39
44f01ed to
3caff35
Compare
This was referenced Nov 14, 2026
elezar
force-pushed
the
feat/5456-write-driver-contract-files/elezar
branch
from
November 16, 2026 12:40
3caff35 to
2ad5f56
Compare
…protobuf Split the file handling into a write side and a read side. write::encode validates a document and returns both files of it, the binary protobuf file and the legacy JSON beside it, each with its name and bytes, encoded from one value so they cannot disagree. read::boundary_config and read::runtime_descriptor prefer the binary file beside a legacy path and fall back to the legacy one; an invalid binary file is an error, not a fallback. read::consume removes every form of a single-use document, and read::descriptor_payload serves the built-in runtime until the legacy encoding is removed. The file naming rule stays internal. The Docker driver writes both forms. The supervisor and the sandbox boundary read through the contract crate. Docker still restarts from its legacy state files, so a narrowly scoped helper reads the optional binary sibling during restart staging. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
feat/5456-write-driver-contract-files/elezar
branch
from
November 16, 2026 15:29
2ad5f56 to
5899380
Compare
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the contract file handling into a write side and a read side, and have the Docker driver write the documents as binary protobuf beside the legacy JSON.
Related Issue
Part of #5456. Stacked on #5508.
Changes
write::encodevalidates a document and returns both files (binary protobuf and legacy JSON), each with its name and bytes, encoded from one value so they cannot disagree.read::boundary_configandread::runtime_descriptorprefer the binary file beside a legacy path and fall back to the legacy one; an invalid binary file is an error, not a fallback.read::consumeremoves every form of a single-use document.read::descriptor_payloadserves the built-in runtime until the legacy encoding is removed. The naming rule stays internal.Release Notes
None.
Testing
rust:deny:policy,buf lintandbuf breakingpass at this tip. Theopenshell-driver-vmtests were not run to completion: they needmke2fs, which was unavailable locally.Checklist