Repository navigation
Conversation
github-actions
Bot
requested review from
FrostGod,
drew,
mrunalp and
russellb
November 12, 2026 09:00
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. rust-sdk — No explicit risk acceptance foundraw::proto::compute::v1::{DriverSandboxSpec, StartSandboxRequest} now include typed_launch_authentication: Option<Box<SandboxLaunchAuthentication>>, which was absent from both structs.
Review details
Advisory review; publication gates are unchanged. |
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 12, 2026 12:38
4efc8ac to
9d94630
Compare
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 12, 2026 12:50
9d94630 to
b1eb5e2
Compare
This was referenced Nov 12, 2026
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 12, 2026 15:24
e58265d to
a7ecd14
Compare
elezar
changed the base branch from
refactor/5456-driver-contract-format/elezar
to
feat/5456-write-driver-contract-files/elezar
November 12, 2026 15:26
elezar
changed the base branch from
feat/5456-write-driver-contract-files/elezar
to
claude/k8s-driver-sdk-ff39cd
November 12, 2026 16:18
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 12, 2026 16:18
a7ecd14 to
5701faa
Compare
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 13, 2026 13:07
5701faa to
33d1a4a
Compare
elezar
requested review from
a team,
derekwaynecarr and
sjenning
as code owners
November 13, 2026 13:07
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 13, 2026 13:39
33d1a4a to
a79f9e1
Compare
This was referenced Nov 14, 2026
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 16, 2026 12:40
a79f9e1 to
d6fe282
Compare
Define the credentials the gateway hands to a driver as protobuf messages in launch_credentials.proto, and carry them as a typed field beside the opaque launch authentication bytes in CreateSandbox and StartSandbox. The gateway sets both, and a driver reads the typed field when present and the bytes otherwise. The SDK converts between the messages and the JWT launch types, which stay in the SDK, and implements the contract crate's Codec for the supervisor auth bundle. The Docker driver writes the bundle as a binary file beside the legacy one, and the supervisor reads it through the contract crate with a preference for the new file. The frozen compute-driver method test finds the service by name, since the package now has a second file. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
feat/5456-typed-launch-authentication/elezar
branch
from
November 16, 2026 15:29
d6fe282 to
f14cd25
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define the credentials the gateway hands to a compute driver as protobuf messages and carry them as a typed field beside the opaque launch authentication bytes in
CreateSandboxandStartSandbox. This is separate from the driver contract documents (#5508, #5519), which a driver produces.Related Issue
Part of #5456. Stacked on #5511 (base is
claude/k8s-driver-sdk-ff39cd).Changes
proto/launch_credentials.proto(packageopenshell.compute.v1) withSandboxLaunchCredentials,SupervisorAuthBundle,LaunchVerificationKeyand the OTLP material messages.Codecfor the supervisor auth bundle. The Docker driver writes the bundle as a binary file beside the legacy one; the supervisor reads it through the contract crate with a preference for the new file.Release Notes
None.
Testing
rust:deny:policy,buf lintandbuf breakingpass at this tip. Theopenshell-driver-vmtests were not run to completion: they needmke2fs, which was unavailable locally.Checklist