Skip to content

feat(driver-sdk): carry the launch authentication as a typed message - #5510

Open
elezar wants to merge 1 commit into
claude/k8s-driver-sdk-ff39cdfrom
feat/5456-typed-launch-authentication/elezar
Open

elezar wants to merge 1 commit into
claude/k8s-driver-sdk-ff39cdfrom
feat/5456-typed-launch-authentication/elezar

Conversation

@elezar

@elezar elezar commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Define the credentials the gateway hands to a compute driver as protobuf messages and carry them as a typed field beside the opaque launch authentication bytes in CreateSandbox and StartSandbox. This is separate from the driver contract documents (#5508, #5519), which a driver produces.

Related Issue

Part of #5456. Stacked on #5511 (base is claude/k8s-driver-sdk-ff39cd).

Changes

  • Add proto/launch_credentials.proto (package openshell.compute.v1) with SandboxLaunchCredentials, SupervisorAuthBundle, LaunchVerificationKey and the OTLP material messages.
  • Add the typed field to the create and start requests. The gateway sets both; a driver reads the typed field when present and the bytes otherwise.
  • The SDK converts between the messages and the JWT launch types, which stay in the SDK, and implements the contract crate's Codec for the supervisor auth bundle. The Docker driver writes the bundle as a binary file beside the legacy one; the supervisor reads it through the contract crate with a preference for the new file.
  • The frozen compute-driver method test finds the service by name, since the package now has a second file.

Release Notes

None.

Testing

  • Checks appropriate to the affected code and behavior pass
    • fmt, clippy, workspace tests, rust:deny:policy, buf lint and buf breaking pass at this tip. The openshell-driver-vm tests were not run to completion: they need mke2fs, which was unavailable locally.
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)
    • Not run on this version.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@elezar elezar added the area:drivers Compute and secret drivers, host OS/architecture support, backend isolation, and lifecycle. label Nov 12, 2026
@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 12, 2026
@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. rust-sdk — No explicit risk acceptance found

raw::proto::compute::v1::{DriverSandboxSpec, StartSandboxRequest} now include typed_launch_authentication: Option<Box<SandboxLaunchAuthentication>>, which was absent from both structs.

  • Impact: Existing Rust consumers using exhaustive literals or patterns fail to compile, while wire clients, default-based constructors, and server implementations without exhaustive construction remain compatible.
  • Action: Preserve the existing raw struct shapes on this no-break train, or defer the addition to a permitted minor release with notice and migration guidance to add typed_launch_authentication: None or use ..Default::default() and non-exhaustive patterns.
  • PR: feat(driver-sdk): carry the launch authentication as a typed message #5510
Review details
  • Execution: complete
  • Candidate: PR #5510 (ff6856b8bf6252946e40ab8251989c65e22d40de)
  • Baseline: d0a42b0aaf2567731dfedafd74e0b171d560a4c1 (d0a42b0aaf2567731dfedafd74e0b171d560a4c1)
  • Reviewed: rust-sdk, python-sdk, go-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from 4efc8ac to 9d94630 Compare November 12, 2026 12:38
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from 9d94630 to b1eb5e2 Compare November 12, 2026 12:50
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from e58265d to a7ecd14 Compare November 12, 2026 15:24
@elezar
elezar changed the base branch from refactor/5456-driver-contract-format/elezar to feat/5456-write-driver-contract-files/elezar November 12, 2026 15:26
@elezar
elezar changed the base branch from feat/5456-write-driver-contract-files/elezar to claude/k8s-driver-sdk-ff39cd November 12, 2026 16:18
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from a7ecd14 to 5701faa Compare November 12, 2026 16:18
@elezar
elezar added this pull request to stack #5532 November 13, 2026 12:35
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from 5701faa to 33d1a4a Compare November 13, 2026 13:07
@elezar
elezar requested review from a team, derekwaynecarr and sjenning as code owners November 13, 2026 13:07
@copy-pr-bot

copy-pr-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from 33d1a4a to a79f9e1 Compare November 13, 2026 13:39
@purp purp added the topic:api Public APIs, gRPC/protobuf, SDK interfaces, versioning, compatibility, and API design standards. label Nov 15, 2026
@purp purp added topic:authnz Authentication, authorization, identity, sessions, credential protection, and policy integrity. topic:documentation Architecture docs, READMEs, project website updates, and automated documentation generation. labels Nov 15, 2026
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from a79f9e1 to d6fe282 Compare November 16, 2026 12:40
Define the credentials the gateway hands to a driver as protobuf messages in
launch_credentials.proto, and carry them as a typed field beside the opaque
launch authentication bytes in CreateSandbox and StartSandbox. The gateway sets
both, and a driver reads the typed field when present and the bytes otherwise.

The SDK converts between the messages and the JWT launch types, which stay in
the SDK, and implements the contract crate's Codec for the supervisor auth
bundle. The Docker driver writes the bundle as a binary file beside the legacy
one, and the supervisor reads it through the contract crate with a preference for
the new file. The frozen compute-driver method test finds the service by name,
since the package now has a second file.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the feat/5456-typed-launch-authentication/elezar branch from d6fe282 to f14cd25 Compare November 16, 2026 15:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:drivers Compute and secret drivers, host OS/architecture support, backend isolation, and lifecycle. state:accepted A maintainer decided OpenShell should pursue this issue topic:api Public APIs, gRPC/protobuf, SDK interfaces, versioning, compatibility, and API design standards. topic:authnz Authentication, authorization, identity, sessions, credential protection, and policy integrity. topic:documentation Architecture docs, READMEs, project website updates, and automated documentation generation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants