Repository navigation
Updates to Configurations for ICARUS MCP - #156
Conversation
|
@grayputnam , do you think this will get in for this upcoming production (finished in 6 days...), or push to sometime after? |
|
Hey Wes! My hope that is that it can be pushed in the next 6 days. |
… propogated to its new location in icaruscode.
|
Hi @gputnam, it looks like this PR is deleting the fcl that was provided to us for running CAFs in ICARUS (i.e. |
|
Hey! It actually moves that configuration to icaruscode with the sibling PR: SBNSoftware/icaruscode#223. So the necessary configurations are all there! |
|
Ok I need to do a couple more tests tomorrow but this should be ready for review! I will mark it as not a draft. |
| // TODO: should the neutrino TOF be subtracted here to get the correct T0? | ||
| return flux.pos.T() + (flux.pos.Vect() - decay).Mag() * (1. / flux.mom.Beta()) / Constants::Instance().c_cm_per_ns; | ||
| // | ||
| // TODO: implement time of flight |
There was a problem hiding this comment.
Is this undoing a TOF correction? I think you're the expert here so I defer to you, just wondered about this choice.
There was a problem hiding this comment.
It is. I had some code to try to implement the TOF of the (massive) LDM. But I decided I didn't trust it so for this production I turned it off. Planning to implement it for the futurue.
| @@ -11,6 +11,10 @@ icarus_numi_beam2detector_rotation: [ 0.921228671, 0.0226872648, 0.388359 | |||
|
|
|||
| icarus_numi_beam_origin: [0, 0, 0, 4.8195e2, 79.5800e2, 794.3955e2] # cm | |||
There was a problem hiding this comment.
Please see SBNSoftware/icaruscode#230 and make sure this is consistent? (It looks like it's not).
This and other geometry pieces look like they'd be better pulled from the geometry service to not need to worry about config in every place? Is there a reason not to do this? If not, I think it's sufficient for now to check the geometry is consistent, but we should make an issue to change this for the next major release.
There was a problem hiding this comment.
hmmm interesting it looks like there's been another update. I'll keep it in mind for the October production, not going to worry about it for now.
As far as if I can pull this from the Geometry service -- I'd love to! But I don't see how. There's now volume definition that matches the ICARUS AV (this is exactly the problem w/ "both cryostats" in GENIE). And the configuration for the beam position you linked to is XML not FCL so I don't see how I can automatically include it.
There was a problem hiding this comment.
Indeed Geometry (as the service) does not know where the targets are.
The transformation matrix is also not known to LArSoft: it's passed straight to GENIEHelper.
I don't see any easy way to get it from LArSoft; a module might be written specifically for that purpose, though.
mroda88
left a comment
There was a problem hiding this comment.
Hi @grayputnam can we just have a comments or two on why the changes in the generation of a proper random seed are requiring changes in the MeV Portal code? I agree with @wesketchum that the changes look like something is still in progress here.
|
@mroda88 the changes to MeVPrtl are orthogonal to the random number generation. That comment was made by Gianluca about one of the aspects of this PR -- but I think he edited my comment in a way that made that unclear. I have since fixed his update to clarify that. |
PetrilloAtWork
left a comment
There was a problem hiding this comment.
There are a couple of action items for the future:
- move ICARUS configuration into
icaruscode(part of this has already happened, but there are detector-specific pieces still around); - extract detector coordinates from the geometry service rather than encoding them in the configuration.
| @@ -11,6 +11,10 @@ icarus_numi_beam2detector_rotation: [ 0.921228671, 0.0226872648, 0.388359 | |||
|
|
|||
| icarus_numi_beam_origin: [0, 0, 0, 4.8195e2, 79.5800e2, 794.3955e2] # cm | |||
There was a problem hiding this comment.
Indeed Geometry (as the service) does not know where the targets are.
The transformation matrix is also not known to LArSoft: it's passed straight to GENIEHelper.
I don't see any easy way to get it from LArSoft; a module might be written specifically for that purpose, though.
| # icarus_detector_box: [-364.49, 364.49, -173.41, 143.41, -909.951, 879.951] | ||
| # icarus_detector_box: [-369.63. 369.63, -224.61, 177.71, -994.950652270838, 994.950652270838] | ||
| icarus_detector_box: [-378.49, 378.49, -191.86, 144.96, -904.950652270838, 904.950652270838] |
There was a problem hiding this comment.
Now this is something that Geometry knows.
I recommend to try to figure out how to get this from LArSoft for the future.
@grayputnam: is this anything that has already been discussed? if not, please open an issue about it.
P.S. I really appreciate the centralisation of these coordinates into a single point.
| transfer_flashmatch_sce_icarus_cryoE: { | ||
| module_type: TransferPFParticleFlashMatch | ||
| PFParticleLabelIn: pandoraGausCryoE | ||
| FlashLabel: fmatchCryoE | ||
| PFParticleLabelOut: pandoraGausSCECryoE | ||
| } | ||
|
|
||
| transfer_flashmatch_sce_icarus_cryoW: { | ||
| module_type: TransferPFParticleFlashMatch | ||
| PFParticleLabelIn: pandoraGausCryoW | ||
| FlashLabel: fmatchCryoW | ||
| PFParticleLabelOut: pandoraGausSCECryoW | ||
| } |
There was a problem hiding this comment.
This also looks like something belonging to icaruscode.
Aaargh! I apologise: that description was meant to be in the |
|
trigger build |
|
CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard |
|
CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
CI build for ICARUS on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for ICARUS on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
cjbacchus
left a comment
There was a problem hiding this comment.
Not really an expert here, but looks broadly fine.
This PR is organizing updates to CAFMaking configurations for use in ICARUS for the upcoming MC production.
This PR also updates the organization of the CAFMaker fcl files. It moves the configurations to fcl/caf. The configurations to run in SBND are in fcl/caf/sbnd. The configurations to run in ICARUS are moved into icaruscode in a sibling PR.
This so far is a draft PR to collect updates needed for the MCP.
[additional irrelevant text was edited away]