Repository navigation
Updates to Configurations for ICARUS MCP - #223
Conversation
|
Also linked: SBNSoftware/icarusalg#34 |
Centralized space charge configuration in G4. Removed duplication of intime_g4 icarus configuration.
standard_detsim_icarus.fcl reintroduced; "multitpc" label should fade out.
Since `perEvent` is not in general safe, `random` was set as new default. This commit sets the policy to `perEvent` for the standard simulation service set (which includes G4 and DetSim). In addition, generators using only RadioGen or SingleGen are set back to `perEvent`, and G4 processes which include generation (e.g. "intime") are set to `random`. Reco configuration happens to happily inherit the simulation configuration (but Reco does not use random numbers anyway, does it??).
|
On Thursday, 5 August 2021 09:11:06 PDT Wesley Ketchum wrote:
@wesketchum requested your review on: SBNSoftware/icaruscode#223 Updates to
Configurations for ICARUS MCP.
Kind of conflict of interest here.
I should not be the only one reviewing, but I can concentrate on the parts I
did not contribute to.
And let's see what happens when I try to answer to a GitHub notification e-
mail.
…--
Gianluca Petrillo
SLAC building 084/B117, mail stop 78
Phone: +1 (650) 926-3088
E-mail: ***@***.***
Instant message: ***@***.*** (jabber)
|
|
I think this is critical for the next release, not the current one (v09_28_00) and so will leave open. I think there is still more work for the MC versions of stage0 and stage1. TBC. |
…ff to the cafmaker defs fcl as done for pandoraTrackGausSCE. Settings meant to be like the previous ones in reco_icarus.fcl but with the CryoW/CryoE names.
…de into feature/MCP2021Reco
|
Pushing commit adding showers. Ran very small tests on a few particle gun MC events just to see that things ran basically. Possibly interestingly, in a test of a few events trying to put in SCE and SCE corr, I found very little difference in the sample having or not having the correction applied. It was not say 0 change for all showers, but in any case I wasn't sure if it should be as small a difference as it was. (just noted for future testing) Also a few other things I believe I noticed from this test:
|
A transitional list of failing tests that still need to be fixed is also added. CAF making configuration files are currently broken in `develop`.
|
I have pushed configurations to generate proton-only cosmic rays with overburden based on the "standard" configuration. |
…fcl format is TBD.
…vert 'multitpc' detsim to be a pass-thru is setup by Gianluca.
|
I have merged in two more feature branches: Tracy's to include latest updates to stage0 / stage1 processing and Jacob's to run Iker's flash matching. Should be ready! So I will make this not a draft anymore. I do want to run a couple more tests before this is merged, but it is ready for review. |
| //std::cout << " totalrms size " << totalRMS.size() << std::endl; | ||
|
|
||
| noise_factor=1; | ||
| // noise_factor=1; ****** not sure why this was done? |
There was a problem hiding this comment.
Can we open an issue related to this so we don't forget that it is commented out?
|
This all looks awesome and I am really excited to have it merged in! |
PetrilloAtWork
left a comment
There was a problem hiding this comment.
My partial review (conflict of interest, remember?) found a couple of potential issues.
- Naming of a few of new proton-only configurations does not follow the existing pattern.
- Hard-coded numbers replicated around: suggesting centralisation.
- PMT decoding appears to have disappeared from one of the configurations.
- one of the job configurations,
stage0_single_icarus.fcl, seems to fail parsing.
Also there is material for a feature request to GENIEGen (it is possible to implement it without even changing GENIEHelper, which means that we can hope to see it soon).
| #Start each new event with an empty event. | ||
| source: | ||
| { | ||
| module_type: RootInput | ||
| maxEvents: -1 # Number of events to create | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd remove this.
| #Start each new event with an empty event. | |
| source: | |
| { | |
| module_type: RootInput | |
| maxEvents: -1 # Number of events to create | |
| } |
| outputs: | ||
| { | ||
| outpid: | ||
| { | ||
| dataTier: cafana # for grid test | ||
| streamName: out1 # for grid test | ||
| module_type: RootOutput | ||
| fileName: "pid_r%r_s%s.root" | ||
| fastCloning: false | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I would really remove this: fastCloning deactivation is questionable, the streamName does not mean anything, the file name is not representative nor well protected against duplication, and all the thing is not used anyway.
| outputs: | |
| { | |
| outpid: | |
| { | |
| dataTier: cafana # for grid test | |
| streamName: out1 # for grid test | |
| module_type: RootOutput | |
| fileName: "pid_r%r_s%s.root" | |
| fastCloning: false | |
| } | |
| } |
There was a problem hiding this comment.
Fixed the bad config -- although the block is used in one of the caf flavors so I am keeping it there.
| # Because this is hardcoded, it needs to be updated for | ||
| # updates to the geometry. This is updates as of | ||
| # geometry: icarus_complete_20210527_no_overburden.gdml | ||
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" |
There was a problem hiding this comment.
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" | |
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" |
This is actually something we can automate.
@jzennamo Care to open a ticket on LArSoft about that?
| @@ -0,0 +1,41 @@ | |||
| # | |||
| # File: prodcorsika_bnb_nue_genie_protononly_icarus.fcl | |||
There was a problem hiding this comment.
According to the surgeon general, this one should be called prodcorsika_genie_protononly_icarus_bnb_nue.fcl.
| services.TFileService.fileName: "Supplemental-prodcorsika_genie_protononly_icarus_%tc-%p.root" | ||
| outputs.out1.fileName: "prodcorsika_genie_protononly_icarus_%tc-%p.root" | ||
| services.TFileService.fileName: "Supplemental-prodcorsika_bnb_genie_protononly_icarus_%tc-%p.root" | ||
| outputs.out1.fileName: "prodcorsika_bnb_genie_protononly_icarus_%tc-%p.root" |
There was a problem hiding this comment.
Considering the existing prodcorsika_genie_protononly_icarus_numi.fcl (and prodcorsika_genie_standard_icarus_numi.fcl), this should be prodcorsika_genie_protononly_icarus_bnb.fcl.
| # * `cosmgen`: generated cosmic rays from CORSIKA | ||
| # | ||
|
|
||
| #include "prodcorsika_genie_standard_icarus.fcl" |
There was a problem hiding this comment.
You can also start from prodcorsika_genie_protononly_icarus_bnb.fcl and override only the particle code.
| # Because this is hardcoded, it needs to be updated for | ||
| # updates to the geometry. This is updates as of | ||
| # geometry: icarus_complete_20210527_no_overburden.gdml | ||
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" |
There was a problem hiding this comment.
Two is one too many. I recommend:
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" | |
| #include "genie_fiducial_cuts_icarus.fcl" | |
| physics.producers.generator.FiducialCut: @local::icarus_allTPCbox |
and fcl/gen/genie/genie_fiducial_cuts_icarus.fcl:
#
# File: genie_fiducial_cuts_icarus.fcl
# Purpose: hard-coded fiducial volume cuts for GENIE generation.
#
BEGIN_PROLOG
# This box includes all TPC active volumes, and just that.
# Because this is hardcoded, it needs to be updated for
# updates to the geometry. This is updates as of
# geometry: icarus_complete_20210527_no_overburden.gdml
icarus_allTPCbox: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838"
END_PROLOG
There was a problem hiding this comment.
We can include this as a future fix but it's still not clear to me that this is the best way to generate genie events in both cryostats, so I'd like to wait before optimizing the config.
|
|
||
| ## Use the following to run the full defined stage0 set of modules | ||
| physics.reco: [@sequence::icarus_stage0_multiTPC] | ||
| physics.reco: [daqTPC, @sequence::icarus_stage0_multiTPC] |
|
Added some commits to address Gianluca's comment and add in CRT hits/tracks to CAF-making |
|
Also I have run the tests that I wanted to! |
|
trigger build |
|
CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard |
|
CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
CI build for ICARUS on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for ICARUS on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
SFBayLaser
left a comment
There was a problem hiding this comment.
I am already familiar with the bulk of the changes and have verified they are working. There are further updates that I think I need to see in action. So I will merge this and then run through my checks on my laptop.
|
❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test ICARUS phase logs parent CI build details are available through the CI dashboard |
|
Ok, the expected outcome of the build since we are still getting things fixed there too. So will merge. |
Updates to ICARUS MC reconstruction for the upcoming MCP.
Right now includes a bugfix in running the stage1 MC reco fcl file and includes a number of configurations to run "CAF" making.
This is intended as a draft PR to collect updates needed for the MCP.
Depends on SBNSoftware/sbncode#156.
ICARUS random number generator policy
To address the issue of
CORSIKAGen(andGENIEGen?) requiring a random number whenNuRandomService(perEventpolicy) is not able to provide one, the policy for random number generation has been changed as follows.random.G4,DetSimand also indirectlyReco) is set toperEvent, to preserve reproducibility.randompolicy.Note that integration test configurations for event generation already explicitly pin down the random number seeds, therefore they are not expected to be broken by this change.
As an aside, I have opened a ticket with LArSoft to address the general issue with
perEventpolicies.MultiTPC DetSim configurations
They are the new
standard.