Date out of range error #143

Activity

1. filak-sap commented on Feb 8, 2021

   

   filak-sap

   on Feb 8, 2021

   Contributor

   More actions

   Well, we can for sure add a workaround (a global variable or something like that) which would cause that any value lower than -62135769600000 would be resolved as 1970-01-01T00:00:00. We haven't added it yet as one of the goals of PyOdata is to test OData service implementation and the value in your case is clearly wrong.

   Feel free to open a PR. I would create a global variable in https://github.com/SAP/python-pyodata/blob/master/pyodata/v2/model.py which would enable a new test in at
   

   python-pyodata/pyodata/v2/model.py

   Line 416 in 6a4eb3b

   value = datetime.datetime(1970, 1, 1, tzinfo=current_timezone()) + datetime.timedelta(milliseconds=int(value))

   value_microseconds = int(value)
   if FIX_SCREWED_UP_MINIMAL_DATETIME_VALUE and value < -62135769600000:
       return datetime.datetime(year=1, day=1, month=1)

   or something like that - it needs to be clearly documented and the error meessage at

   python-pyodata/pyodata/v2/model.py

   Line 418 in 6a4eb3b

   raise PyODataModelError('Cannot decode datetime from value {}.'.format(value))

   should provide a hint.

   Please, add also test case.

   👍React with 👍1Reacted by Timo S.
2. sti0

   added a commit that references this issue on Mar 19, 2021

   SAP#143 Workaround for screwed up date values

   ...

   2923f74
3. filak-sap

   closed this as completedin #149on Mar 20, 2021
4. filak-sap

   added a commit that references this issue on Mar 20, 2021

   Workaround for screwed up date values (#149)

   ...

   7846065