Date value out of range #80

Activity

1. filak-sap commented on Jan 29, 2020

   

   filak-sap

   on Jan 29, 2020

   Contributor

   More actions

   Thank you for taking the time to report the issue and sorry for the late reply.

   Can you please send me the data in JSON format? (Add $format=json to URL).
2. asmaMdi commented on Feb 3, 2020

   

   asmaMdi

   on Feb 3, 2020

   Author

   More actions

   Hi,
   Thank you for your reply please find attached json file because I'm not allowed to put the url
   EmployeeData.zip
3. filak-sap commented on Feb 6, 2020

   

   filak-sap

   on Feb 6, 2020

   Contributor

   More actions

   @asmaMdi I'm sorry but you provided XML. It's not enough to store it in *.json you need to download it as JSON.

   The following examples shows the difference:

   Example XML:
   https://services.odata.org/V2/Northwind/Northwind.svc/Employees

   Example JSON:
   https://services.odata.org/V2/Northwind/Northwind.svc/Employees?$format=json
4. filak-sap

   added a commit that references this issue on Feb 7, 2020

   test: validate parsing boundary values JSON Dates

   ...

   c1fe591
5. filak-sap commented on Feb 7, 2020

   

   filak-sap

   on Feb 7, 2020

   Contributor

   More actions

   I am really wondering what's the content of JSON because I tested pyodata with values for 0001-01-01T00:00:00 and also 9999-12-31T00:00:00 and both worked fine.
6. asmaMdi commented on Feb 10, 2020

   

   asmaMdi

   on Feb 10, 2020

   Author

   More actions

   Hi,
   sorry for my delayed response. Please find attached file.
   EmployeeData.zip
7. filak-sap commented on Feb 10, 2020

   

   filak-sap

   on Feb 10, 2020

   Last edited by filak-sap

   Contributor

   More actions

   @asmaMdi Thank you very much indeed. The minimal value in your data is represented by the number -62135769600000 which is 172799999miliseconds greater than the current lowest value PyOData can read (-62135596800000).

   If you subtract the date 0001-01-01T00:00:00 (your lowest value) from 1970-01-01T00:00:00 (OData base date) you get maximal value which -62135596800000.

   import datetime
   
   int((datetime.datetime(year=1, day=1, month=1) - datetime.datetime(year=1970, day=1, month=1)).total_seconds()) * 1000
   
   # result = -62135596800000

   If you subtract your lowest value from PyOData lowest value and add the result to the OData zero date, you get 1970-01-02T23:59:999000.

   import datetime
   
   datetime.datetime(year=1970, day=1, month=1) + datetime.timedelta(milliseconds=-62135596800001-(-62135769600000))
   
   # result = datetime.datetime(1970, 1, 2, 23, 59, 59, 999000)

   Can you, please, report the issue to your OData service provider?

   An excerpt of you data:

      {"__metadata":{"uri":"https://{REMOVED_HOST}/sap/byd/odata/cust/v1/odata_project/EmployeeEmployeeTypeCollection('0000000000011EE181BFC430CB1AAE84')",
      "type":"cust.EmployeeEmployeeType"},
      "ObjectID":"0000000000011EE181BFC430CB1AAE84",
      "ParentObjectID":"0000000000011EE181BFC41244F70E84",
      "EndDate":"\/Date(253402214400000)\/",
      "StartDate":"\/Date(-62135769600000)\/",
     "InternalEmployeeIndicator":false,

   The corresponding XML excerpt:

   <link href="EmployeeEmployeeTypeCollection('0000000000011EE181BFC430CB1AAE84')/Employee" rel="http://schemas.microsoft.com/ado/2007/08/dataservices/related/Employee" type="application/atom+xml;type=entry" title="Employee"/>
   <content type="application/xml">
   <m:properties>
   <d:ObjectID>0000000000011EE181BFC430CB1AAE84</d:ObjectID>
   <d:ParentObjectID>0000000000011EE181BFC41244F70E84</d:ParentObjectID>
   <d:EndDate>9999-12-31T00:00:00</d:EndDate>
   <d:StartDate>0001-01-01T00:00:00</d:StartDate>
   <d:InternalEmployeeIndicator>false</d:InternalEmployeeIndicator>
   </m:properties>
   </content>
8. asmaMdi commented on Feb 12, 2020

   

   asmaMdi

   on Feb 12, 2020

   Author

   More actions

   Thank your for your response. I will see with the OData service provider.
9. filak-sap commented on Feb 12, 2020

   

   filak-sap

   on Feb 12, 2020

   Contributor

   More actions

   @asmaMdi If they refuse to fix the problem on their side, we will find a way how to work around this issue.
10. asmaMdi commented on Feb 13, 2020

    

    asmaMdi

    on Feb 13, 2020

    Author

    More actions

    Great! Thank you very much
    I reported the problem to the OData service provider.

    Thank you
11. filak-sap commented on Feb 24, 2020

    

    filak-sap

    on Feb 24, 2020

    Contributor

    More actions

    @asmaMdi thank you for the follow up. I am going to close this issue and I would like to ask you to re-open, if the service provider does not fix the issue on their side. I would like to thank you for your cooperation and patience.
12. filak-sap

    closed this as completedon Feb 24, 2020
13. squeakyboots commented on Apr 3, 2020

    

    squeakyboots

    on Apr 3, 2020

    More actions

    @asmaMdi did you hear back from the provider? I also seem to be facing this issue on ByD and am curious what the outcome was.