Skip to content

Bump Loop and LoopKit: Settings › Display - #562

Merged
ps2 merged 1 commit into
next-devfrom
bump/next-dev-display-options
Oct 26, 2026
Merged

ps2 merged 1 commit into
next-devfrom
bump/next-dev-display-options

Conversation

@ps2

@ps2 ps2 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bumps Loop and LoopKit on next-dev for the new Settings › Display screen.

Defaults match today's behavior. Built with the LoopWorkspace scheme on Xcode 27.1 for the simulator (19 plugins).

…ime window)

- LoopKit/LoopKit#667: chart now line, fixed glucose scale and x-axis label spacing
- LoopKit/Loop#2613: Settings › Display with Now Line, Glucose Scale and Time Window
@marionbarker

Copy link
Copy Markdown
Contributor

Test

✅ Successful test of feature
❌ Failed tests

  • multiple tests failed in class LoopDataManagerTests

Configuration

Configure LoopWorspace for bump/next-dev-display-options.

Test Details

Build onto SE 3rd gen running iOS 27.0.1.

  • pump is simulator
  • cgm is Nightscout

Settings has new Display Row.

  • test enable now line - works nicely
  • test fixed 40 to 400 scaling
  • test the various history/forecast display selections

@ps2

ps2 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

CircleCI has failed twice on this PR, each time in different tests, all timing-sensitive and outside what this bump touches:

  • 1310: CriticalEventLogExportManagerTests.testExport (10 s timeout) and testExportPartial (temp file missing)
  • 1311: CarbStoreHKQueryTests.testHKQueryAnchorPersistence (3 s timeout) and GlucoseStoreTestSharingUndetermined.testHealthKitQueryAnchorPersistence (Core Data store not open); the hosted test app also restarted partway through

The tests that failed in one run passed in the other. The bump only changes chart code, PredictedGlucoseChartTests, the status screen, Settings and LoopConstants.

Local run of the same command CI uses (xcodebuild -scheme LoopWorkspace ... test) at bd69f5d on a fresh iPhone 17 simulator (iOS 27.0): ** TEST SUCCEEDED **, all bundles passed. The four tests above each took 0.03–0.05 s.

My guess is that a slow or overloaded CI machine is hitting the timeouts and setup races in these tests, and the bump isn't the cause.

@ps2
ps2 merged commit 18d9cbb into next-dev Oct 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants