Repository navigation
Bump Loop, LoopAlgorithm and LoopOnboarding: Guard + Runway experiment, welcome screen width - #557
Merged
Merged
Conversation
…t, welcome screen width - LoopAlgorithm: optional algorithm experiments (LoopKit/LoopAlgorithm#10), type renamed to ExperimentOption (LoopKit/LoopAlgorithm#11) - Loop: use LoopAlgorithm's experiments, and add Guard + Runway (LoopKit/Loop#2608) - LoopOnboarding: limit the welcome screen to a readable width (LoopKit/LoopOnboarding#39)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExperimentOptionso it doesn't clash with LoopKit'sAlgorithmExperiment(Rename AlgorithmExperiment to ExperimentOption LoopAlgorithm#11).All experiments are off by default; users turn them on under Settings → Algorithm Experiments, which standard builds show (
ALLOW_ALGORITHM_EXPERIMENTSis set in LoopConfigOverride.xcconfig). Tested locally with Loop and LoopAlgorithm at these commits and LoopKit at next-dev: the LoopWorkspace scheme builds, and LoopTests (344) and LoopKitTests (507) pass.