Repository navigation
Rename AlgorithmExperiment to ExperimentOption - #11
Merged
Merged
Conversation
LoopKit declares a public AlgorithmExperiment (the record stored with dosing decisions), so files importing both modules could not use either name unqualified, and LoopAlgorithm.AlgorithmExperiment resolves to the LoopAlgorithm struct. Encoded fixtures are unchanged: they store the raw values.
This was referenced Oct 24, 2026
AndEliRich
pushed a commit
to AndEliRich/LoopWorkspace
that referenced
this pull request
Oct 24, 2026
…t, welcome screen width - LoopAlgorithm: optional algorithm experiments (LoopKit/LoopAlgorithm#10), type renamed to ExperimentOption (LoopKit/LoopAlgorithm#11) - Loop: use LoopAlgorithm's experiments, and add Guard + Runway (LoopKit/Loop#2608) - LoopOnboarding: limit the welcome screen to a readable width (LoopKit/LoopOnboarding#39)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10. LoopKit already declares a public
AlgorithmExperiment(the record stored with dosing decisions and uploaded to Tidepool and Nightscout), so any file importing both LoopKit and LoopAlgorithm got "'AlgorithmExperiment' is ambiguous". Qualifying doesn't help on this side, becauseLoopAlgorithm.AlgorithmExperimentresolves to theLoopAlgorithmstruct.Type rename only; raw values and encoded fixtures are unchanged.
swift testpasses (179).Used by LoopKit/Loop#2608.