Repository navigation
Show manual glucose entries as a larger red point on the watch - #2612
Merged
Merged
Conversation
Matches the phone charts (LoopKit/LoopKit#666): in the watch app's glucose chart and the complication chart, a user-entered sample that isn't display-only is drawn red and 1 pt larger than the CGM points. The watch already receives wasUserEntered with each sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The watch app's glucose chart and the complication chart now draw user-entered glucose (fingersticks, calibration values, Nightscout meter readings) red and 1 pt larger than the CGM points. This matches the phone charts in LoopKit/LoopKit#666.
A sample counts as manual when it's user-entered and not display-only, the same test the phone HUD uses (
SampleValue.isManualGlucoseinCommon). The watch already receiveswasUserEnteredwith each sample, through both the live context and the glucose backfill, so nothing changes in the phone-to-watch transfer.Plain
.redis used becausesystemRedisn't available on watchOS, and the watch background is always black.Testing
Watch simulator (watchOS 27.0) paired with an iOS simulator running this branch, LoopKit/LoopKit#666 and LoopKit/LoopAlgorithm#14: a 135 fingerstick shows as a red point among simulator CGM readings at 120 on the watch chart page. The complication chart wasn't checked in the simulator.