This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Repository navigation
WiP: Fix configvar substitution - #64
Closed
NubiaNetworks wants to merge 7 commits into
Closed
NubiaNetworks wants to merge 7 commits into
NubiaNetworks wants to merge 7 commits into
Conversation
Contributor
|
I'd rather do the fix in a more general way. |
…itution' into fix-configvar-substitution
Author
|
Initializing the |
Contributor
|
Basically you're right! But my take was that this showed that what we had was too fragile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a testcase to demonstrate that variable substitution does currently not work for deeper levels, e.g. for
clients/flop/redirect_urls