flask_rp does not substitute {host} an {port} in configuration #62

Activity

1. rohe commented on Mar 4, 2022

   

   rohe

   on Mar 4, 2022

   Contributor

   More actions

   I'd like to see the configuration file you're using.
2. NubiaNetworks commented on Mar 4, 2022

   

   NubiaNetworks

   on Mar 4, 2022

   Author

   More actions

   I'm using the default config.json files from oid-cop 'flask_op' and JWTConnect-Python-OidcRP's flask_rp

   On the flask_op side I'm getting:

   2022-03-04 08:49:30,205 oidcmsg.configure INFO request: {'application_type': 'web', 'response_types': ['code'], 'contacts': ['ops@example.com'], 'token_endpoint_auth_method': 'client_secret_basic', 'backchannel_logout_uri': 'https://{domain}:{port}/bc_logout/local', 'frontchannel_logout_uri': 'https://{domain}:{port}/fc_logout/local', 'redirect_uris': ['https://{domain}:{port}/authz_cb/local'], 'jwks_uri': 'https://127.0.0.1:8090/static/jwks.json', 'post_logout_redirect_uri': 'https://{domain}:{port}/session_logout/local', 'frontchannel_logout_session_required': True, 'grant_types': ['authorization_code']}
   

   On the flask_rp side:

   2022-03-04 08:49:30,235 oidcrp.util DEBUG resp.headers: {'Content-type': 'application/json; charset=utf-8', 'Content-Length': '927', 'Pragma': 'no-cache', 'Cache-Control': 'no-store', 'Set-Cookie': 'oidc_op_rp=1646380170|pmCefI6WW93GHwUs|ZMrqXRI2dWwfWkoqLmMrZBTKy0pEiGt5r2iLzMdoGj/W7Qo4m8bXPQnT1DGlmlsaKzMhc6i2UV5SY5GqrSkIyN16fMp89DUSoFvJCVQ8/l84jDBGbDKhFTxtTOsNOIKamUUanFCohpA=|4JyiuFp7pJ+gYNMSxYu8Hw==; Secure; HttpOnly; Path=/; SameSite=Lax', 'Server': 'Werkzeug/2.0.3 Python/3.9.9', 'Date': 'Fri, 04 Mar 2022 07:49:30 GMT'}
   2022-03-04 08:49:30,235 oidcrp.util DEBUG resp.txt: {"client_id": "Qo1it0yxWiUGLHIGf0Q3vQ", "registration_access_token": "BOZZssAxbiWUWhUJ4GrpFWjBc2RHV4615-42P17DhXI", "registration_client_uri": "https://127.0.0.1:5000/registration_api?client_id=Qo1it0yxWiUGLHIGf0Q3vQ", "client_id_issued_at": 1646380170, "client_secret": "7cab69b50b0416a99dc35996399f60aaf8b157a83cae0ba11a5cadb9", "client_secret_expires_at": 1648972170, "application_type": "web", "response_types": ["code"], "contacts": ["ops@example.com"], "token_endpoint_auth_method": "client_secret_basic", "backchannel_logout_uri": "https://{domain}:{port}/bc_logout/local", "frontchannel_logout_uri": "https://{domain}:{port}/fc_logout/local", "jwks_uri": "https://127.0.0.1:8090/static/jwks.json", "post_logout_redirect_uri": "https://{domain}:{port}/session_logout/local", "frontchannel_logout_session_required": true, "grant_types": ["authorization_code"], "redirect_uris": ["https://{domain}:{port}/authz_cb/local"]}
   
3. rohe commented on Mar 4, 2022

   

   rohe

   on Mar 4, 2022

   Contributor

   More actions

   Which versions of OidcRP and oidc-op ?
4. NubiaNetworks commented on Mar 4, 2022

   

   NubiaNetworks

   on Mar 4, 2022

   Author

   More actions

   Both the git default branches.

   I noticed that the actual substitution is supposed to happen in the Base class in the oidcmsg package which is version 1.6.0
5. rohe commented on Mar 4, 2022

   

   rohe

   on Mar 4, 2022

   Contributor

   More actions

   Let me get back to you later today or tomorrow. A bit busy right now.

   👍React with 👍1Reacted by NubiaNetworks
6. NubiaNetworks commented on Mar 4, 2022

   

   NubiaNetworks

   on Mar 4, 2022

   Last edited by NubiaNetworks

   Author

   More actions

   In #64 I created a test case to demonstrate the issue
   It turned out to be a bug regarding an omitted 'uris' variable in RPConfigure.
   Fix in the same pull request