Skip to content

Task/merge 3.6 test setup - #55

Merged
tobiasgruber merged 8 commits into
Flowpack:mainfrom
tobiasgruber:task/merge-3.6-test-setup
Nov 17, 2026
Merged

tobiasgruber merged 8 commits into
Flowpack:mainfrom
tobiasgruber:task/merge-3.6-test-setup

Conversation

@tobiasgruber

Copy link
Copy Markdown
Contributor

TASK: Run functional tests against Neos 9

  • the test distribution installs Neos 9 (NEOS_VERSION, default 9.2),
    including the content graph adapter and Neos UI like the base distribution
  • AbstractFusionTestCase builds the Fusion runtime from FusionGlobals
  • tests use PHPUnit 11 attributes
  • CI runs Neos 9.0 on PHP 8.2 and Neos 9.2 on PHP 8.4
  • README: versioning scheme table

BUGFIXES:

  • Always link first and last page in pagination
    • The first page was only prepended if the displayed range started after page 2, the last page only appended if it ended before the second to last page. With maximumNumberOfLinks = 5, page 3 rendered '2 3 4 ... 10' without a link to page 1, page 8 rendered '1 ... 7 8 9' without page 10.
  • Cast numberOfPages to Int so it is never a float

The first page was only prepended if the displayed range started after page 2, the last page only appended if it ended before the second to last page. With maximumNumberOfLinks = 5, page 3 rendered '2 3 4 ... 10' without a link to page 1, page 8 rendered '1 ... 7 8 9' without page 10.

Now the first/last page is added whenever it is outside the displayed range, and the '...' separator only if there is an actual gap.
…rst-last-link

Functional Test Setup and Bugfix for pagination first last link
  - the test distribution installs Neos 9 (NEOS_VERSION, default 9.2),
    including the content graph adapter and Neos UI like the base distribution
  - AbstractFusionTestCase builds the Fusion runtime from FusionGlobals
  - tests use PHPUnit 11 attributes
  - CI runs Neos 9.0 on PHP 8.2 and Neos 9.2 on PHP 8.4
  - README: versioning scheme table
@tobiasgruber
tobiasgruber merged commit daa358c into Flowpack:main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant