Repository navigation
Functional Test Setup and Bugfix for pagination first last link - #54
Merged
tobiasgruber merged 3 commits intoNov 17, 2026
Merged
Conversation
The first page was only prepended if the displayed range started after page 2, the last page only appended if it ended before the second to last page. With maximumNumberOfLinks = 5, page 3 rendered '2 3 4 ... 10' without a link to page 1, page 8 rendered '1 ... 7 8 9' without page 10. Now the first/last page is added whenever it is outside the displayed range, and the '...' separator only if there is an actual gap.
tobiasgruber
force-pushed
the
bugfix/pagination-first-last-link
branch
from
November 17, 2026 14:23
9258fe1 to
5d5c0f1
Compare
Contributor
Author
|
@skurfuerst reviewed this locally on my machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧱 TASK: Add functional test setup and GitHub CI
🐛 BUGFIX: Always link first and last page in pagination
The first page was only prepended if the displayed range started after page 2, the last page only appended if it ended before the second to last page. With maximumNumberOfLinks = 5, page 3 rendered '2 3 4 ... 10' without a link to page 1, page 8 rendered '1 ... 7 8 9' without page 10.
Now the first/last page is added whenever it is outside the displayed range, and the '...' separator only if there is an actual gap.