Repository navigation
Enforce source-bound Fbuild PR gates - #1637
Conversation
Local-Gate: v1 tree=4d5064a4071a02518339cd4bad680249a56aa7d1 secs=224 lanes=linux-minimal:run
Ci-Attestation: {"at":1791024365,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"b07767312a6d13ec17d1c7877ce534c14e61fea19376563dc4da6a657a6b905d","lane":"linux-minimal","parents":["8246c30990859bb41740215c0b075bc6fdb4e474"],"secs":224,"stamp":"4bc7f1d5a30c07a9521a238f2ed96a7e","tree":"4d5064a4071a02518339cd4bad680249a56aa7d1","v":1,"via":"run"}
Ci-Attestation: {"at":1791024365,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"b07767312a6d13ec17d1c7877ce534c14e61fea19376563dc4da6a657a6b905d","lane":"linux-minimal","parents":["8246c30990859bb41740215c0b075bc6fdb4e474"],"secs":224,"stamp":"88325819622c56a1f1397de84e4f7d16","tree":"4d5064a4071a02518339cd4bad680249a56aa7d1","v":1,"via":"run"}
Ci-Attestation: {"at":1791024365,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"b07767312a6d13ec17d1c7877ce534c14e61fea19376563dc4da6a657a6b905d","lane":"linux-minimal","parents":["8246c30990859bb41740215c0b075bc6fdb4e474"],"secs":224,"stamp":"0070b69664e8d2c24cb68afb9aa5d029","tree":"4d5064a4071a02518339cd4bad680249a56aa7d1","v":1,"via":"run"}
Ci-Attestation: {"at":1791024365,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"b07767312a6d13ec17d1c7877ce534c14e61fea19376563dc4da6a657a6b905d","lane":"linux-minimal","parents":["8246c30990859bb41740215c0b075bc6fdb4e474"],"secs":224,"stamp":"c5d8cca98852c88db04e471c23f0c52e","tree":"4d5064a4071a02518339cd4bad680249a56aa7d1","v":1,"via":"run"}
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe local gate changes from shadow mode to enforcement for PR attestations. Proof verification now requires the ChangesLocal gate enforcement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The test still protects the shadow-mode reuse decision. The PR verifier is configured for pull requests, though its behavior when proof is missing was not established by the available evidence. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change tightens pull-request checks without adding verifier permissions or replacing remote tests. No introduced security vulnerability was established. Risk remains low rather than minimal because the separately supplied attestation verifier’s authentication, source-binding, and failure behavior could not be independently confirmed. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fbuild now has a proven source-bound local gate, but shadow mode still lets an unattested PR start its runner fan-out. Enforce the attestation before minimal-workflow jobs start. Non-PR events keep the verifier job successful, so default-branch and dispatch coverage continue.
The local gate runs the existing workflow-dispatch event to execute the same required Ubuntu workspace and ignored facade commands before stamping the tree. Its frozen proof now requires dispatch evidence; PR event records cannot substitute for that proof. Board, extended/full and other native coverage remain remote, and no quick-gate skipping is enabled.
Validation: regression failed on shadow mode, then 26 focused checks passed; Ruff and sole-primary review passed. Published bosn 0.1.11 executed the full declared gate in 224s (963a50d7-4f74-4fed-ace2-3cfaf2820bad). Real
ci-lint local-gate verify --event pull_requestrejects the unsigned head with exit 1 and accepts the stamped head. Only the existing ci-minimal workflow changes, through its generator.Follows #1636 (merged at 8246c30). Refs #1635. Coordinated with forge-ci/ci.yml#259 (evidence update; follows #258). Full fleet migration and the 100% first-push target remain unproven.