Skip to content

Add source-bound bosn act2 Ubuntu gate in shadow mode - #1636

Merged
zackees merged 3 commits into
mainfrom
feat/bosn-act2-local-gate
Oct 3, 2026
Merged

zackees merged 3 commits into
mainfrom
feat/bosn-act2-local-gate

Conversation

@zackees

@zackees zackees commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Fbuild lacked a source-bound local proof for its two required Ubuntu jobs. Add a clean-tree bosn/act2 gate that requires successful workspace Clippy/tests and ignored Python-facade tests, plus four per-gate commit attestations. The generated minimal entrypoint verifies in shadow mode; every existing board/full/native job and test command remains.

The unchanged-main local baseline failed to link libpython3.12. Select uv-managed Python 3.12 explicitly for the workspace job, keeping the facade job on Python 3.10 and preserving separate cache suffixes.

That failed link also saved incomplete caches because neither setup-soldr call supplied job-status. Both now pass the final job status; rotate only the failed workspace generation to check-ubuntu-py312-v1. A real private fixture compiled, exited 42 and confirmed both layers report failed-job-skip. The test wrapper now streams Cargo JSON compiler evidence and preserves the original exit code and test selection. Only a completed assertion failure enables save-on-failure; compiler errors, missing completion evidence and cancellation remain blocked. A real assertion-failure workflow (520a2bfd-58e3-478b-b71f-351fb8d4faed) remained failed while both permitted cache layers saved; a real compiler-failure probe returned 101 with the opt-in false.

Validation:

  • Declared local gate passed twice: 284s and forced warm execution 286s, both required jobs successful. Warm execution is not faster yet; thin-cache fallback still rebuilds workspace leaf crates. Re-running an attested head returns immediately without engine work.
  • 24 focused proof/workflow/cache-writer checks and pre-push reviews pass; malformed, stale, dirty, failed, skipped and incomplete records reject.
  • Latest cache-status correction passed the declared local gate in 583s on a fresh workspace cache generation (run 042053f9-07ad-40af-8e87-2a3dd1aeee26), and was stamped before push. A forced warm engine run 075544e9-0d2d-4886-b1b9-0eeb3c12d40c passed both jobs in 247s, restoring the fresh build-cache seed exactly; workspace test compilation fell from 140.98s to 95.76s. Remote ci-minimal 37114988442 and full-target Dylint 37114988158 both passed on this corrected head. The 284s/286s and first green remote run below describe the preceding tree.
  • First remote run is green: ci-minimal 37112762596 completed both Ubuntu jobs, Arduino Uno/ESP32/Teensy board builds and selected coverage; Dylint 37112761945 completed the full all-OS-target pass. All normal static and board-definition workflows passed. Extended/full labeled coverage was not invoked.
  • Broader CI guard cache-key uniqueness failure reproduces on unchanged main. Existing standalone verifier/Rust-tool/CodeRabbit policy findings remain tracked debt, without exceptions.

forge-ci/bosn#442 is merged and its validated 0.1.11 release is published (full CI 37114032741, dry run 37114605896, publication 37115034048 all green). It publishes the merged stock-runner-tools fix forge-ci/bosn#441 (6ae32cd7dca8947af69863cd1df12fca7779c40a); published v0.1.10 predates that fix. Local evidence used a wheel built from that exact source. The released PyPI wheel installs and reports 0.1.11. A forced declared gate through that installed release passed both required Ubuntu jobs in 245s (run 3f5c046c-bfb3-4030-b5d9-7073f92a362a), independently of the source-built candidate. The subsequent cache-outcome correction passed the full declared gate through published Bosn in 238s (e694c2e1-86a0-4f60-84ec-1cfceaf51aa8), and code review passed. Latest-head remote verification passed: ci-minimal 37116500210 completed both Ubuntu jobs, shared binary, all three selected boards and the coverage aggregator; full all-OS-target Dylint 37116499972 passed. All ordinary static and board-definition checks passed. This is the initial shadow rollout; enforced PR verification and broader local coverage remain follow-up work, and no 100% first-push claim is made. No remote quick-gate skipping is enabled.

Refs #1635; fleet evidence forge-ci/ci.yml#253.

Local-Gate: v1 tree=97ec665f5af3fa774be7454d047fa51e1e6ce456 secs=0 lanes=linux-minimal:reused@cf62da74fbbe
Ci-Attestation: {"at":1791019243,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"cf62da74fbbe9895db8b6c14d6ed3ef49ccdf49cb6cd48d4486cae3ef269bd5e","lane":"linux-minimal","parents":["6acb66a2f54ff879dc0e23b3577861b69c80cbe1"],"secs":null,"stamp":"0e33a801bcd2ea96eece6db73d19ee3d","tree":"97ec665f5af3fa774be7454d047fa51e1e6ce456","v":1,"via":"reused"}
Ci-Attestation: {"at":1791019243,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"cf62da74fbbe9895db8b6c14d6ed3ef49ccdf49cb6cd48d4486cae3ef269bd5e","lane":"linux-minimal","parents":["6acb66a2f54ff879dc0e23b3577861b69c80cbe1"],"secs":null,"stamp":"d88d0f066396a8664b244e8b03635c0e","tree":"97ec665f5af3fa774be7454d047fa51e1e6ce456","v":1,"via":"reused"}
Ci-Attestation: {"at":1791019243,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"cf62da74fbbe9895db8b6c14d6ed3ef49ccdf49cb6cd48d4486cae3ef269bd5e","lane":"linux-minimal","parents":["6acb66a2f54ff879dc0e23b3577861b69c80cbe1"],"secs":null,"stamp":"972cd10362060782d303eb23a280e1f3","tree":"97ec665f5af3fa774be7454d047fa51e1e6ce456","v":1,"via":"reused"}
Ci-Attestation: {"at":1791019243,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"cf62da74fbbe9895db8b6c14d6ed3ef49ccdf49cb6cd48d4486cae3ef269bd5e","lane":"linux-minimal","parents":["6acb66a2f54ff879dc0e23b3577861b69c80cbe1"],"secs":null,"stamp":"26d0c0db8a089d102900a72eaa8206b4","tree":"97ec665f5af3fa774be7454d047fa51e1e6ce456","v":1,"via":"reused"}
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 142fb9c4-e4b3-4d52-851a-9d7fadd1a019
📥 Commits

Reviewing files that changed from the base of the PR and between 6acb66a and a4512c0.

📒 Files selected for processing (11)
  • .github/workflows/check-ubuntu.yml
  • .github/workflows/ci-minimal.yml
  • ci-attestations.yml
  • ci/README.md
  • ci/local_gate.py
  • ci/render_workflows.py
  • ci/test_cache_status.py
  • ci/test_fractional_workflows.py
  • ci/test_local_gate.py
  • ci/test_test_cache_status.py
  • local-gate.toml
 __________________________________________________________
< Solving problems you didn't know you were about to have. >
 ----------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Local-Gate: v1 tree=ddcfc5246492c0f6597aa9454c7ff143e6e85267 secs=245 lanes=linux-minimal:run
Ci-Attestation: {"at":1791022568,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"6d1a90d731d1f111d2184d5ad41b917989c1022ff6b9ae093ff023f2bc1aca02","lane":"linux-minimal","parents":["c14693b5bd06e962415190753bbc3c752fde6540"],"secs":245,"stamp":"98238d06ddd76ba9fb54ad9be26e62d2","tree":"ddcfc5246492c0f6597aa9454c7ff143e6e85267","v":1,"via":"run"}
Ci-Attestation: {"at":1791022568,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"6d1a90d731d1f111d2184d5ad41b917989c1022ff6b9ae093ff023f2bc1aca02","lane":"linux-minimal","parents":["c14693b5bd06e962415190753bbc3c752fde6540"],"secs":245,"stamp":"b60fe842c8c03dcc14a4832b6473a74e","tree":"ddcfc5246492c0f6597aa9454c7ff143e6e85267","v":1,"via":"run"}
Ci-Attestation: {"at":1791022568,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"6d1a90d731d1f111d2184d5ad41b917989c1022ff6b9ae093ff023f2bc1aca02","lane":"linux-minimal","parents":["c14693b5bd06e962415190753bbc3c752fde6540"],"secs":245,"stamp":"1591552eb3264a60f308b8846544fbe7","tree":"ddcfc5246492c0f6597aa9454c7ff143e6e85267","v":1,"via":"run"}
Ci-Attestation: {"at":1791022568,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"6d1a90d731d1f111d2184d5ad41b917989c1022ff6b9ae093ff023f2bc1aca02","lane":"linux-minimal","parents":["c14693b5bd06e962415190753bbc3c752fde6540"],"secs":245,"stamp":"f14cbe0ccd4c0ff0073cac5bb8ac6017","tree":"ddcfc5246492c0f6597aa9454c7ff143e6e85267","v":1,"via":"run"}
Local-Gate: v1 tree=8335396bc6a85278cbd3f0272a23d35c6960701c secs=238 lanes=linux-minimal:run
Ci-Attestation: {"at":1791023183,"gate":"general/all/ubuntu-ci-guards","host":"linux-x86_64","key":"141738f90792d11f317ee76463cfacfac9e86db8d6d8f6d7f030385ba7ea539f","lane":"linux-minimal","parents":["945c170aecba3fccd31443c30bf52f22d8a6993c"],"secs":238,"stamp":"b13fb42582552a237488e92d7da98b5f","tree":"8335396bc6a85278cbd3f0272a23d35c6960701c","v":1,"via":"run"}
Ci-Attestation: {"at":1791023183,"gate":"rust/x86_64-unknown-linux-gnu/workspace-clippy","host":"linux-x86_64","key":"141738f90792d11f317ee76463cfacfac9e86db8d6d8f6d7f030385ba7ea539f","lane":"linux-minimal","parents":["945c170aecba3fccd31443c30bf52f22d8a6993c"],"secs":238,"stamp":"093fec80b229bd8e00778b80d2db59ec","tree":"8335396bc6a85278cbd3f0272a23d35c6960701c","v":1,"via":"run"}
Ci-Attestation: {"at":1791023183,"gate":"rust/x86_64-unknown-linux-gnu/workspace-test","host":"linux-x86_64","key":"141738f90792d11f317ee76463cfacfac9e86db8d6d8f6d7f030385ba7ea539f","lane":"linux-minimal","parents":["945c170aecba3fccd31443c30bf52f22d8a6993c"],"secs":238,"stamp":"71aa318ebf16f77378b0e03cdce951fc","tree":"8335396bc6a85278cbd3f0272a23d35c6960701c","v":1,"via":"run"}
Ci-Attestation: {"at":1791023183,"gate":"rust/x86_64-unknown-linux-gnu/python-facade-test","host":"linux-x86_64","key":"141738f90792d11f317ee76463cfacfac9e86db8d6d8f6d7f030385ba7ea539f","lane":"linux-minimal","parents":["945c170aecba3fccd31443c30bf52f22d8a6993c"],"secs":238,"stamp":"2bcaf6a52dbaeea51ad6908ab50a4e55","tree":"8335396bc6a85278cbd3f0272a23d35c6960701c","v":1,"via":"run"}
@zackees
zackees force-pushed the feat/bosn-act2-local-gate branch from f56be51 to a4512c0 Compare October 3, 2026 10:27
@zackees
zackees marked this pull request as ready for review October 3, 2026 10:39
@zackees
zackees merged commit 8246c30 into main Oct 3, 2026
24 checks passed
@zackees
zackees deleted the feat/bosn-act2-local-gate branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant