Repository navigation
fix(tests): re-enable skipped tests from Rust migration (#39) - #54
Merged
Merged
Conversation
- Delete MicrophoneHttpsIntegrationTest class (HTTPS dropped in PR #48) - Keep MicrophoneDemoValidationTest for micdemo.html content validation - Remove #39 tracking references from skip markers - Add test_http_server.py: HTTP smoke test using the Rust CLI binary - Fix pre-existing pyright errors (playwright import suppressions) - Fix pre-existing black formatting in playwright module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MicrophoneHttpsIntegrationTest— HTTPS tests no longer applicable after dropping Flask/HTTPS in PR feat: replace Flask with Rust HTTP server (#45) #48MicrophoneDemoValidationTest(validates micdemo.html content)#39reference fromtest_cli.pyskip markertest_http_server.py— smoke test that spawns the Rust CLI with--serve-dir, fetches index.html, verifies 200 responseplaywright_browser.pyandresize_tracking.pyNew test:
HttpServerSmokeTestReplaces the deleted HTTPS integration tests. Locates the Rust CLI binary (distinguishes from maturin wrappers by size >10MB and help output), starts it with
--serve-dir, parses the auto-assigned port, makes an HTTP request, and verifies a 200 response.Test plan
bash lint— 0 pyright errorsbash test— 120 tests pass (119 existing + 1 new)Closes #39