Skip to content

fix: re-enable skipped tests from Rust migration #39

Closed

Description

@zackees

Context

During the Rust migration (#38), several tests were identified as broken or needing attention on CI. These are tracked here for follow-up.

Skipped/Broken Tests

Integration Tests

  • test_microphone_https.py (entire class) — Skipped on CI. The Flask HTTPS server times out on macOS CI runners (both ARM and x86). wait_for_server() can't connect within 15s. Works locally. Likely a CI networking/firewall issue.

Unit Tests

  • test_cli.py::MainTester::test_command — Skipped on CI. Requires full WASM toolchain (emscripten + esbuild + binaryen). Fails with different errors per platform:

Auto-skipped Tests (expected)

  • test_animartrix_e2e.py — Auto-skips when ~/dev/fastled/examples/Animartrix doesn't exist (expected on CI)

Root Causes

  1. HTTPS server timeout (macOS CI): Flask server spawns but connections to localhost:PORT timeout. May need to bind to 127.0.0.1 explicitly or increase timeout on CI.
  2. Emscripten toolchain incomplete on macOS: .emscripten config missing BINARYEN_ROOT. The clang-tool-chain installer may not set this correctly on macOS ARM.
  3. test_cli.py is really an integration test: It runs a full WASM compilation pipeline. Should potentially be moved to tests/integration/.

Action Items

  • Investigate macOS CI HTTPS server timeout
  • Fix emscripten .emscripten config to include BINARYEN_ROOT on all platforms
  • Consider moving test_cli.py to integration tests
  • Re-enable skipped tests once root causes are fixed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions