Skip to content

chore(ci): reuse CI artifacts in auto-release, cache dylint toolchain - #172

Merged
zackees merged 1 commit into
mainfrom
chore/soldr-ci-phase2
Jun 12, 2026
Merged

zackees merged 1 commit into
mainfrom
chore/soldr-ci-phase2

Conversation

@zackees

@zackees zackees commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

Phase 2 (structural fixes) of #170:

  • Explicit rust-targets in CI build wrappers: the five native build wrappers now pass the same rust-target as their auto-release counterparts, so CI wheels/binaries are release-identical (same plat-name tags, artifact names, soldr cache keys). Also fixes a latent bug: macos-14 runners are Apple Silicon, so the previous "macOS x86" native build actually shipped an arm64 binary.
  • auto-release reuses CI artifacts: a new collect-artifacts job waits (≤35 min) for the six CI build runs on the release SHA and re-publishes their wheel/binary artifacts into the release run. Each platform build-* job is now a fallback that runs only when its CI artifact is missing, failed, or timed out; workflow_dispatch always builds. create-tag accepts success || skipped from each build, so a fully-reused release builds nothing. This removes ~80 min of duplicate platform builds per version bump.
  • dylint caching in _lint.yml: the nightly-2026-03-26 toolchain, cargo-dylint/dylint-link binaries, and ~/.dylint_drivers are cached via actions/cache keyed on the exact versions — the dominant 10+ min fixed cost of every lint job now pays only on cache miss. Per the maintainer's request, the remaining bare rustup call now goes through soldr rustup (the rust-toolchain.toml toolchain is already covered by setup-soldr's soldr toolchain ensure).

Together with #171 this addresses the per-push compute waste quantified in #170 (~207 min baseline). The warm-then-fan-out restructure was deliberately deferred: with #171's unified cache keys, cross-push cache sharing already covers most of the duplicate dep compilation, and a needs: warm gate would serialize the pipeline and increase wall-clock latency.

Test plan

  • All workflows parse as YAML; actionlint clean (validates the needs graph, expressions, and shellchecks the collect script)
  • bash lint green, 18/18 unit tests
  • Collect-script output-key derivation verified locally (linux-x86-build.yml → reused_linux_x86, etc.)
  • CI on this PR green (exercises the modified _lint.yml + build wrappers directly; first run warms the dylint cache, subsequent runs hit it)
  • Next version bump: verify auto-release reuses CI artifacts (build-* jobs skipped) and PyPI/GH release artifacts are intact

Refs #170

…uted rustup

Phase 2 of the setup-soldr audit (Refs #170):

- Give the five native CI build wrappers explicit rust-targets so their
  wheels/binaries are identical to auto-release's (same plat-name tags,
  artifact names, and soldr cache keys). Also fixes the latent macOS x86
  bug where the "native" build on Apple-Silicon macos-14 runners produced
  an arm64 binary under the x86 name.
- auto-release: add a collect-artifacts job that waits for the CI build
  runs on the release SHA and reuses their artifacts; each of the six
  platform builds now runs only as a fallback when its CI artifact is
  missing, failed, or timed out. workflow_dispatch always builds.
  Eliminates ~80 min of duplicate release builds per version bump.
- _lint.yml: cache the dylint nightly toolchain, cargo-dylint/dylint-link
  binaries, and dylint drivers (the 10+ min fixed cost of every lint job),
  and install the dylint nightly via `soldr rustup` instead of bare rustup
  so soldr-managed toolchain homes stay consistent.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@zackees
zackees merged commit 090cacc into main Jun 12, 2026
22 checks passed
@zackees
zackees deleted the chore/soldr-ci-phase2 branch June 12, 2026 06:42
zackees added a commit that referenced this pull request Jun 12, 2026
…ative dylint cache (#174)

The #172 change routed the dylint nightly install through `soldr rustup`,
which installs into soldr's private toolchain home instead of the
setup-soldr-exported RUSTUP_HOME, so the dylint driver build lost its
rustc-dev components and failed with E0463 on all four lint platforms.

Install the nightly with bare rustup (unconditional — it is not part of
the dylint cache), and replace the hand-rolled actions/cache step with
setup-soldr's native dylint-cache inputs, gating the cargo-dylint /
dylint-link installs on its dylint-cache-hit output.

Refs #170

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant