Repository navigation
chore(ci): unify soldr versions, per-target cache keys, drop name-only ARM wrappers - #171
Merged
Merged
Conversation
…y ARM wrappers Phase 1 drift fixes from the setup-soldr audit (Refs #170): - Remove the known-broken `version: 0.7.53` pins from _lint.yml, _unit-test.yml, _integration-test.yml, and linux-x86-dwarf-smoke.yml so all reusable workflows resolve the same soldr/zccache version as _build.yml (unpinned per #158) and stop splitting warm caches. - Key the soldr cache on the rust target as well as the runner label: _build.yml uses `<runs-on>-<rust-target|native>`, lint/test workflows use `<runs-on>-native`, so cross-compile targets sharing a runner no longer thrash one key while same-platform jobs share one namespace. - Delete the windows-arm lint/unit-test/integration-test wrappers: they ran on x86 `windows-2025` hosts and were byte-identical duplicates of the windows-x86 wrappers, adding zero ARM coverage. Real ARM coverage remains via the aarch64-pc-windows-msvc cross-compile build. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 (drift fixes) of #170:
version: 0.7.53pins from_lint.yml,_unit-test.yml,_integration-test.yml, andlinux-x86-dwarf-smoke.ymlso every reusable workflow resolves the same soldr/zccache version as_build.yml(unpinned per ci: Windows ARM Build broken since soldr v0.7.53 pin — revert _build.yml to v0.7.51 #158) and caches are no longer split across lint/test vs build._build.ymlnow keys the soldr cache on<runs-on>-<rust-target|native>so cross-compile targets sharing a runner label (e.g.windows-2025hosting both x86_64 and aarch64 builds) stop thrashing one key; lint/test workflows use<runs-on>-nativeso same-platform jobs share one cache namespace with the native build.windows-2025hosts as byte-identical duplicates of the windows-x86 wrappers, adding zero ARM coverage while costing ~30 min of compute per push. Real ARM coverage remains via theaarch64-pc-windows-msvccross-compile build (windows-arm-build.yml).Phase 2 (warm-then-fan-out, auto-release artifact reuse, dylint caching) is tracked separately in #170.
Test plan
grep "version: 0.7.53"returns no matches under.github/workflows/bash lintgreen,pytest tests/unit18/18 (no code changes; workflows only)_lint/_unit-test/_integration-test/_buildworkflows directly)Refs #170