Skip to content

fix: --init uses latest release but build always uses master #115

Closed

Description

@zackees

Bug

After fixes #111, #113, #114, fastled --just-compile --quick fails on the sketch compile step:

wasm.ino:1:10: fatal error: 'fl/sketch_macros.h' file not found

Cause

  • fastled --init wasm downloads from the latest release of FastLED (3.10.3 currently), where the example wasm.ino uses #include "fl/sketch_macros.h".
  • The build path (crates/fastled-cli/src/wasm_build.rs:815) unconditionally calls install::ensure_fastled_repo(Some("master")) and compiles against master.
  • In master, this header was moved to fl/system/sketch_macros.h, so the include fails.

Fix sketch

Build against the same ref that --init initialized with. Options:

  • Persist the ref in a file like <sketch_dir>/.fastled-version at init time, and read it back during build.
  • Or have resolve_fastled_dir honour --latest, --branch, --commit flags consistently with --init.

Refs

Blocks #56 testing.

Activity

  1. zackees commented on Jun 2, 2026

    @zackees
    MemberAuthor

    Resolved by merged PR #118 (e008ca3e). Current origin/main pins the initialized FastLED ref into fastled.json and resolve_fastled_dir reads that saved ref back during builds, so init/build use the same FastLED checkout instead of always forcing master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions