You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: emscripten manifest parse fails when versions are top-level keys #111
fastled --just-compile fails on the very first run with:
fastled: emscripten toolchain install failed: parse manifest JSON from https://raw.githubusercontent.com/zackees/clang-tool-chain-bins/main/assets/emscripten/win/x86_64/manifest.json: missing field `versions` at line 7 column 1
Cause
The published manifest at assets/emscripten/<plat>/<arch>/manifest.json looks like:
But crates/fastled-cli/src/install.rs defines PlatformManifest with a required versions: BTreeMap<String, VersionInfo> field, so deserialization fails.
The doc-comment on that struct already calls this out: 'older ctcb-manifest releases expected version keys at the top level' — but the struct does not currently accept that older shape.
Resolved by merged PR #118 (e008ca3e). Current origin/main implements parse_platform_manifest, accepting both nested versions manifests and legacy top-level version-key manifests, with regression tests for legacy top-level manifests and invalid latest/no-version cases.
Activity
zackees commentedon Jun 2, 2026
Resolved by merged PR #118 (
e008ca3e). Currentorigin/mainimplementsparse_platform_manifest, accepting both nestedversionsmanifests and legacy top-level version-key manifests, with regression tests for legacy top-level manifests and invalid latest/no-version cases.