Skip to content

mypy: Clean out or report issues in mypy/typeshed for type: ignores #142

Closed

Description

@timabbott

Now that we've finished #127, it's worth doing a bit of work on the type: ignores in our mypy annotations, trying to fix upstream in typeshed anything where that's possible.

I don't want this issue to remain open forever, so we should happily close this as soon as we've done a sweep through our type: ignore entries.

@neiljp I feel like you'd probably be pretty effective at doing this.

Activity

  1. neiljp commented on Nov 15, 2017

    @neiljp
    Contributor

    @zulipbot claim

  2. neiljp commented on Nov 16, 2017

    @neiljp
    Contributor

    #157 Should cover most of this, I think?

    I think I had a copy/paste issue, as the work on generate_manifest.py I intended to link to
    python/mypy#1747, which was my reported issue; the corresponding PR I just worked on is python/mypy#1748.

  3. timabbott commented on Nov 16, 2017

    @timabbott
    SponsorMemberAuthor

    Yeah, this seems good enough for this issue (though of course you're welcome to contribute fixes upstream to clean this out further!). Thanks @neiljp!

  4. neiljp commented on Dec 21, 2017

    @neiljp
    Contributor

    For the record, the correct links I reported and which are now fixed were in python/typeshed, not python/mypy. I'm just putting together a PR which removes these ignores and upgrades to mypy 0.560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions