Repository navigation
ci: clear real precheck needs_review findings (GATE-012, GEN-003) (#50) - #77
Merged
Merged
Conversation
…al entry points (#50) GATE-012: the id-token job's if now names workflow_dispatch literally. GEN-003: ci.toml [suites.unit]/[suites.smoke] named ci/test.py and ci/wheel.py, which never existed; they now name ci/fast.py rust-test and ci/fast.py wheel-install, which the fast job runs. Local-Gate: v1 tree=055faf90077d0ca2b5b602adc660d2c3a422830d secs=448 lanes=precheck:run,fast:run,dylint:run Ci-Attestation: {"at":1793011437,"gate":"rust/x86_64-unknown-linux-gnu/fast","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"a57b2686a3229269297dde5b19ca5261","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"} Ci-Attestation: {"at":1793011437,"gate":"python/all/fast","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"801c4107bc325f0f9c4afd59085128a3","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"} Ci-Attestation: {"at":1793011437,"gate":"general/x86_64-unknown-linux-gnu/wheel-install","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"508cdeafe9e4232a0da73dcc5ad1eeef","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"} Ci-Attestation: {"at":1793011437,"gate":"rust/all/dylint","host":"linux-x86_64","key":"206715758052f1a955eee466eedcd59da67732dca97af89c426ddb4afa8d72d3","lane":"dylint","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"7de5ee9e61802107a187f0dd0a108998","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #50 (forge-ci/ci.yml#52). ci-lint
precheck --local(forge-ci/ci.yml HEAD) needs_review: 33 -> 30. The 37 count in the brief came from an older checker build.Fixed:
publish(id-token: write) job'sif:now saysgithub.event_name == 'workflow_dispatch'literally. oidc-check already required that event, so coverage is unchanged.[suites.unit]/[suites.smoke]namedci/test.py unitandci/wheel.py smoke, which never existed. They now nameci/fast.py rust-testandci/fast.py wheel-install, which the fast job runs.Left as checker false positives (no exceptions added):
if:has!cancelled(), a status function, and that already overrides the skipped-needs cascade. Proof: PR run 40285095554 ranfastsuccessfully whilereuse-decisionandcache-maintwere skipped. That disproves ci.yml: thefastquick-gate job is skipped on every pull_request by a needs-chain skip cascade #67's premise too.cache-maintedges order the pre-prune before writer saves (a real cache dependency) and only exist on writer flows. Thequeue-janitoredges are required by GEN-022.cancel-in-progressis false on push and schedule.Deferred: RUST-022 (blocked until setup-soldr ships the lint deps layer, #110), plus the 4 live-only skips.
Local gate passed (448s, attested).