Skip to content

ci: clear real precheck needs_review findings (GATE-012, GEN-003) (#50) - #77

Merged
zackees merged 1 commit into
mainfrom
fix/precheck-needs-review-50
Oct 26, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/precheck-needs-review-50

Conversation

@zackees

@zackees zackees commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Part of #50 (forge-ci/ci.yml#52). ci-lint precheck --local (forge-ci/ci.yml HEAD) needs_review: 33 -> 30. The 37 count in the brief came from an older checker build.

Fixed:

  • GATE-012 x1: the publish (id-token: write) job's if: now says github.event_name == 'workflow_dispatch' literally. oidc-check already required that event, so coverage is unchanged.
  • GEN-003 x2: ci.toml [suites.unit]/[suites.smoke] named ci/test.py unit and ci/wheel.py smoke, which never existed. They now name ci/fast.py rust-test and ci/fast.py wheel-install, which the fast job runs.

Left as checker false positives (no exceptions added):

  • WF-004 x6: every flagged dependent's if: has !cancelled(), a status function, and that already overrides the skipped-needs cascade. Proof: PR run 40285095554 ran fast successfully while reuse-decision and cache-maint were skipped. That disproves ci.yml: the fast quick-gate job is skipped on every pull_request by a needs-chain skip cascade #67's premise too.
  • GEN-024 x9: the cache-maint edges order the pre-prune before writer saves (a real cache dependency) and only exist on writer flows. The queue-janitor edges are required by GEN-022.
  • CACHE-038 x5: the suffixes resolve through the composite to the distinct values ''/dylint/platform-build/release/perf. platform-build legs differ by cross-target, and setup-soldr folds that into the toolchain digest (resolve-setup.ts mergeToolchainTargets).
  • RUN-001 x2: literal matrix runs_on values, all fleet labels.
  • RUN-003 x2: arm lanes are reached only through ci-full/release tags or nightly; flow.pr is linux-x64 only.
  • CACHE-016 x1: cancel-in-progress is false on push and schedule.

Deferred: RUST-022 (blocked until setup-soldr ships the lint deps layer, #110), plus the 4 live-only skips.

Local gate passed (448s, attested).

…al entry points (#50)

GATE-012: the id-token job's if now names workflow_dispatch literally.
GEN-003: ci.toml [suites.unit]/[suites.smoke] named ci/test.py and
ci/wheel.py, which never existed; they now name ci/fast.py rust-test and
ci/fast.py wheel-install, which the fast job runs.

Local-Gate: v1 tree=055faf90077d0ca2b5b602adc660d2c3a422830d secs=448 lanes=precheck:run,fast:run,dylint:run
Ci-Attestation: {"at":1793011437,"gate":"rust/x86_64-unknown-linux-gnu/fast","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"a57b2686a3229269297dde5b19ca5261","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"}
Ci-Attestation: {"at":1793011437,"gate":"python/all/fast","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"801c4107bc325f0f9c4afd59085128a3","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"}
Ci-Attestation: {"at":1793011437,"gate":"general/x86_64-unknown-linux-gnu/wheel-install","host":"linux-x86_64","key":"6099727ac8ef066b58cea3917384207746896639468901a70c6166f6f2c4eacd","lane":"fast","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"508cdeafe9e4232a0da73dcc5ad1eeef","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"}
Ci-Attestation: {"at":1793011437,"gate":"rust/all/dylint","host":"linux-x86_64","key":"206715758052f1a955eee466eedcd59da67732dca97af89c426ddb4afa8d72d3","lane":"dylint","parents":["8e86c604ebbe086c8db88e549d9b128821f743bc"],"secs":448,"stamp":"7de5ee9e61802107a187f0dd0a108998","tree":"055faf90077d0ca2b5b602adc660d2c3a422830d","v":1,"via":"run"}
@zackees
zackees merged commit e572aa4 into main Oct 26, 2026
21 checks passed
@zackees
zackees deleted the fix/precheck-needs-review-50 branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant