Repository navigation
[release] ci: drop the Linux x64 cross-target workaround (#39) - #60
Merged
Merged
Conversation
zackees
force-pushed
the
m2-47-soldr-wheel-lanes
branch
from
October 21, 2026 22:42
f9a7ba3 to
3c0ee45
Compare
…--release gives manylinux_2_17 (#39)
zackees
force-pushed
the
m2-47-release-linux-x64-soldr-wheel
branch
from
October 22, 2026 01:44
332017e to
7c1bc04
Compare
zackees
marked this pull request as ready for review
October 22, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39. Follows merged #59.
Remove
cross-target: x86_64-unknown-linux-gnufrom Linux x64 release setup and remove its explicit--targetbuild argument. Keep the directsoldr wheel --releasepath, sdist verification,manylinux_2_17policy, and the existing GLIBC check against the actual staged artifact.Resumed checkpoint
The two original #39 commits have been rebased locally onto the reviewed #59 head
afe71267faecd5870fe1f6d3448df47c8e42d68e, producing revieweda50df56, then rebased unchanged onto merged main as7c1bc04. The resulting diff is limited to the existing workflow, its policy comments and release documentation. Parsed YAML and diff checks pass; parsed TOML equality verifies that every policy value remains unchanged.The upstream default dependency is now available: setup-soldr's exact-main contract and full fbuild canary passed, followed by successful manual promotion 39706672687.
setup-soldr@v0now selects the qualified 0.9.38 action. #59 merged as65d6c95add2e0d65af4cf79ddecddd7441535a7dafter its exact-head checks passed.The refreshed commits are pushed and this PR targets main. Review passed. Mandatory local precheck with release selection passed with zero violations; the final tree matches the reviewed checkpoint. The requested release rehearsal passed at the final head; the artifact and policy results are recorded below.
Completed release qualification
Exact head
7c1bc047f235a73b68a1fb7e92b4383d83196b92passed full release run 39707416841. Logs confirm setup-soldr resolved the promoted6bf04d4196ee26fe9d51550187013a7f32955e20action and soldr 0.9.38. The host-target build runsci/release.py build --out dist/release-linux-x64without the explicit target. The staged wheel's actual maximum required version isGLIBC_2.16, so its retainedmanylinux_2_17floor check passes. Sdist-to-wheel smoke retains the bundled CLI. Native platform runs, musl smoke, release verification and final CI OK pass. No precheck policy violations were reported.